Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect error message for opto stimulus site #524

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Fix incorrect error message for opto stimulus site #524

merged 5 commits into from
Oct 2, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Oct 2, 2024

Motivation

The error message is incorrect.

@rly rly requested a review from stephprince October 2, 2024 19:57
@rly rly enabled auto-merge (squash) October 2, 2024 19:57
stephprince
stephprince previously approved these changes Oct 2, 2024
@stephprince stephprince dismissed their stale review October 2, 2024 22:02

tests failing

@rly
Copy link
Contributor Author

rly commented Oct 2, 2024

Thanks for updating the test! You'll have to re-approve.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (c453b68) to head (77065e3).
Report is 2 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #524      +/-   ##
==========================================
+ Coverage   82.77%   86.83%   +4.05%     
==========================================
  Files          47       47              
  Lines        1504     1504              
==========================================
+ Hits         1245     1306      +61     
+ Misses        259      198      -61     
Files with missing lines Coverage Δ
src/nwbinspector/checks/_ogen.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@rly rly merged commit ba7d845 into dev Oct 2, 2024
38 checks passed
@rly rly deleted the rly-patch-1 branch October 2, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants