Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect error message for opto stimulus site #524

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Fix incorrect error message for opto stimulus site #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a761f9
Fix incorrect error message for opto stimulus site
rly Oct 2, 2024
11839aa
Merge branch 'dev' into rly-patch-1
rly Oct 2, 2024
114fbf7
Merge branch 'dev' into rly-patch-1
stephprince Oct 2, 2024
ffd4d6e
update opto assertion
stephprince Oct 2, 2024
77065e3
update CHANGELOG.md
stephprince Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
* Swapped setup approach to the modern `pyproject.toml` standard. [#507](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/507)
* Added complete annotation typing and integrated Mypy into pre-commit. [#520](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/520)

### Fixes
* Fixed incorrect error message for OptogeneticStimulusSite. [#524](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/524)


# v0.5.2
Expand Down
2 changes: 1 addition & 1 deletion src/nwbinspector/checks/_ogen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ def check_optogenetic_stimulus_site_has_optogenetic_series(
if obj.site == ogen_site:
return None

return InspectorMessage(message="OptogeneticStimulusSite is not referenced by any OptogeneticStimulusSite.")
return InspectorMessage(message="OptogeneticStimulusSite is not referenced by any OptogeneticSeries.")
2 changes: 1 addition & 1 deletion tests/unit_tests/test_ogen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@ def test_check_pass(self):
def test_check_triggered(self):
assert (
check_optogenetic_stimulus_site_has_optogenetic_series(self.ogen_site).message
== "OptogeneticStimulusSite is not referenced by any OptogeneticStimulusSite."
== "OptogeneticStimulusSite is not referenced by any OptogeneticSeries."
)
Loading