-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: Bump black to >=23.1.0 #96
base: develop
Are you sure you want to change the base?
Conversation
@NiklasRosenstein I didn't totally understand how to add the |
Thanks for the contribution @mcintel! You can mimic the same format after generating a fresh uuid for the |
@NiklasRosenstein Ah, thanks for the info. I see that the verify failed. I'll try to repro and fix. Thanks for this tool! It's super rad! 😁 |
Along with this, also needed to bump pydoc-markdown. And for good measure, added docs/_site to .gitignore so `slap run docs:build` won't show a bunch of new files to add.
My version of mypy required this, but the GitHub actions is flagging it as unused.
Glad you like it ❤️ Black needs to be pinned to a major version as the next major version will most likely have breaking formatting changes; as demonstrated by the Python 3.7 tests (which get a 23.x version and all the other tests get the latest 24.x version). One workaround would be to run Black for linting in this project separately from the runtime dependency; but I would say we can just drop the 3.7 support all together since that Python version is no longer supported. |
Along with this, also needed to bump pydoc-markdown. And for good measure, added docs/_site to .gitignore so
slap run docs:build
won't show a bunch of new files to add.