Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Bump black to >=23.1.0 #96

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changelog/_unreleased.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[[entries]]
id = "7e6f481f-0e4b-4502-981c-cf98a757dd6d"
type = "improvement"
description = "Bump black to `>=23.1.0`"
author = "@mcintel"
2 changes: 1 addition & 1 deletion .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10", "3.x"]
python-version: ["3.8", "3.9", "3.10", "3.x"]
project: ["docspec", "docspec-python"]
steps:
- uses: actions/checkout@v3
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
build/
.vscode/
.python-version
docs/_site

# Generate files for documentation.
changelog.md
Expand Down
4 changes: 2 additions & 2 deletions docspec-python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ homepage = "https://github.com/NiklasRosenstein/docspec/"
packages = [{ include = "docspec_python", from="src" }]

[tool.poetry.dependencies]
python = "^3.7"
python = "^3.8"
docspec = "^2.2.1"
"nr.util" = ">=0.7.0"
black = "^23.1.0"
black = "^24.4.2"

[tool.poetry.dev-dependencies]
black = "*"
Expand Down
10 changes: 4 additions & 6 deletions docspec-python/src/docspec_python/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,24 +91,22 @@ def load_python_modules(


@t.overload
def parse_python_module(
def parse_python_module( # noqa
filename: t.Union[str, Path],
module_name: t.Optional[str] = None,
options: t.Optional[ParserOptions] = None,
encoding: t.Optional[str] = None,
) -> Module:
...
) -> Module: ...


@t.overload
def parse_python_module(
def parse_python_module( # noqa
fp: t.TextIO,
filename: t.Union[str, Path],
module_name: t.Optional[str] = None,
options: t.Optional[ParserOptions] = None,
encoding: t.Optional[str] = None,
) -> Module:
...
) -> Module: ...


def parse_python_module( # type: ignore
Expand Down
15 changes: 5 additions & 10 deletions docspec-python/src/docspec_python/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,15 @@ def dedent_docstring(s: str) -> str:


@t.overload
def find(predicate: t.Callable[[T], t.Any], iterable: t.Iterable[T], as_type: None = None) -> T | None:
...
def find(predicate: t.Callable[[T], t.Any], iterable: t.Iterable[T], as_type: None = None) -> T | None: ... # noqa


@t.overload
def find(predicate: t.Callable[[T], t.Any], iterable: t.Iterable[T], as_type: type[V]) -> V | None:
...
def find(predicate: t.Callable[[T], t.Any], iterable: t.Iterable[T], as_type: type[V]) -> V | None: ... # noqa


@t.overload
def find(predicate: None, iterable: t.Iterable[T], as_type: type[V]) -> V | None:
...
def find(predicate: None, iterable: t.Iterable[T], as_type: type[V]) -> V | None: ... # noqa


def find(
Expand Down Expand Up @@ -149,13 +146,11 @@ def find(


@t.overload
def get(predicate: t.Callable[[T], object], iterable: t.Iterable[T], as_type: None = None) -> T:
...
def get(predicate: t.Callable[[T], object], iterable: t.Iterable[T], as_type: None = None) -> T: ... # noqa


@t.overload
def get(predicate: t.Callable[[T], object], iterable: t.Iterable[T], as_type: type[V]) -> V:
...
def get(predicate: t.Callable[[T], object], iterable: t.Iterable[T], as_type: type[V]) -> V: ... # noqa


def get(predicate: t.Callable[[T], object], iterable: t.Iterable[T], as_type: type[V] | None = None) -> T | V:
Expand Down
2 changes: 1 addition & 1 deletion docspec/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ homepage = "https://github.com/NiklasRosenstein/docspec/"
packages = [{include="docspec", from="src"}]

[tool.poetry.dependencies]
python = "^3.7"
python = "^3.8"
"databind.core" = "^4.2.6"
"databind.json" = "^4.2.6"
Deprecated = "^1.2.12"
Expand Down
10 changes: 4 additions & 6 deletions docspec/src/docspec/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -515,17 +515,15 @@ def load_modules(


@t.overload
def dump_module(
def dump_module( # noqa
module: Module, target: t.Union[str, t.IO[str]], dumper: t.Callable[[t.Any, t.IO[str]], None] = json.dump
) -> None:
...
) -> None: ...


@t.overload
def dump_module(
def dump_module( # noqa
module: Module, target: None = None, dumper: t.Callable[[t.Any, t.IO[str]], None] = json.dump
) -> t.Dict[str, t.Any]:
...
) -> t.Dict[str, t.Any]: ...


def dump_module(
Expand Down
2 changes: 1 addition & 1 deletion docspec/test/docspec/test_deserialize.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def test_serialize_deserialize(module: docspec.Module) -> None:
assert deser == module

def _deep_comparison(a: t.Any, b: t.Any, path: list[str | int], seen: set[int]) -> None:
assert type(a) == type(b), path
assert isinstance(a, type(b)), path
if isinstance(a, weakref.ref):
a, b = a(), b()
assert a == b, path
Expand Down
2 changes: 1 addition & 1 deletion slap.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ enabled = false
"docs:dev" = "cd docs && novella --serve"

[install.extras]
docs = ["mako", "mkdocs", "mkdocs-material", "novella==0.1.15", "pydoc-markdown==4.6.0", "databind ^1.5.0"]
docs = ["mako", "mkdocs", "mkdocs-material", "novella==0.1.15", "pydoc-markdown >=4.6.0", "databind >=1.5.0"]