Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NK3AM: LED should blink when prompting for the user input #93

Closed
sosthene-nitrokey opened this issue Oct 19, 2022 · 3 comments · Fixed by #451
Closed

NK3AM: LED should blink when prompting for the user input #93

sosthene-nitrokey opened this issue Oct 19, 2022 · 3 comments · Fixed by #451

Comments

@sosthene-nitrokey
Copy link
Collaborator

The NK3A NFC blinks when waiting for user input but the NK3AM shines. It should blink when it is waiting for user input.
@robin-nitrokey
Copy link
Member

robin-nitrokey commented Oct 19, 2022 •
edited
Loading

Which firmware version did you test this with? Looking at the code, it should have been ported from lpc55 to nrf52/embedded but maybe @daringer knows more.

@sosthene-nitrokey
Copy link
Collaborator Author

sosthene-nitrokey commented Oct 19, 2022 •
edited
Loading

v1.2.2-alpha.opcard.0.1.0 and v1.2.2

@robin-nitrokey robin-nitrokey mentioned this issue Oct 20, 2022
Closed
@daringer daringer mentioned this issue Jul 19, 2023
Merged
@daringer
Copy link
Collaborator

While cleaning/fixing the LED blinking also remove this line, as it is redundant:

nitrokey-3-firmware/runners/embedded/src/soc_nrf52840/trussed_ui.rs

Line 99 in 102f2eb

self.set_status(ui::Status::WaitingForUserPresence);

robin-nitrokey added a commit that referenced this issue Mar 4, 2024
@robin-nitrokey
nk3am: Remove blocking UP check
55d8517 
Since this commit [0] that changed the threshold from 3 to 1, the
blocking loop in the user presence check for the NK3AM does no longer
have any functional effect.  But it has undesired side effects, for
example skipping the UI update for a second so that the blinking effect
is not triggered, and delaying the handling of cancelled requests.

This patch removes the unnecessary blocking loop.  The button
implementation still requires 100 ticks to trigger a button press.

Fixes: #93

[0] 35dac8d
@robin-nitrokey robin-nitrokey mentioned this issue Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nk3am: Remove blocking UP check Nitrokey/nitrokey-3-firmware
3 participants
@daringer @robin-nitrokey @sosthene-nitrokey