nk3am: Remove blocking UP check #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
approved these changes
Mar 4, 2024
daringer
approved these changes
Mar 4, 2024
Since this commit [0] that changed the threshold from 3 to 1, the blocking loop in the user presence check for the NK3AM does no longer have any functional effect. But it has undesired side effects, for example skipping the UI update for a second so that the blinking effect is not triggered, and delaying the handling of cancelled requests. This patch removes the unnecessary blocking loop. The button implementation still requires 100 ticks to trigger a button press. Fixes: #93 [0] 35dac8d
robin-nitrokey
force-pushed
the
nk3am-button
branch
from
55d8517
to
95fedf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this commit [0] that changed the threshold from 3 to 1, the blocking loop in the user presence check for the NK3AM does no longer have any functional effect. But it has undesired side effects, for example skipping the UI update for a second so that the blinking effect is not triggered, and delaying the handling of cancelled requests.
This patch removes the unnecessary blocking loop. The button implementation still requires 100 ticks to trigger a button press.
Fixes: #93
[0] 35dac8d