Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #11804 from obsidiansystems/remove-old-make" #11826

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Revert "Merge pull request #11804 from obsidiansystems/remove-old-make" #11826

merged 1 commit into from
Nov 8, 2024

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Nov 7, 2024 •
edited
Loading

Motivation

Annoying I know, but we should have at least one release cycle where the new build system is feature-complete before removing the old one. A bit of soak time allows resolving issues like:

  • Why is ninjaBuildPhase 34 seconds slower than buildPhase with the old build system? (Might be because it's building the API docs by default, or because it's building the tests, which ideally would be done on ninjaCheckPhase only.)
  • Should we be building the API docs by default? They cause ninjaBuildPhase to spit out a huge amount of warnings on every incremental build.
  • A hang in ninjaCheckPhase (ninjaCheckPhase hangs in flakes/develop test #11827).
  • The removal of the nix package. packages.x86_64-linux contains 293 packages (which is a UX problem in itself), but not the one you would expect... (Flake nix package #11822)

So I would suggest we branch off 2.25 soon and then revert this revert. Alternatively we can branch off 2.25 and apply this revert to that branch.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@edolstra
Revert "Merge pull request NixOS#11804 from obsidiansystems/remove-ol…
67d231c 
…d-make"

This reverts commit 619eeb6, reversing
changes made to 1af94bf.
@github-actions github-actions bot added documentation new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority store Issues and pull requests concerning the Nix store fetching Networking with the outside (non-Nix) world, input locking c api Nix as a C library with a stable interface labels Nov 7, 2024
@Mic92 Mic92 merged commit aeffdef into NixOS:master Nov 8, 2024
17 checks passed
@edolstra edolstra deleted the revert-11804 branch November 8, 2024 12:00
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-11-06-nix-team-meeting-minutes-192/55847/2

edolstra added a commit to DeterminateSystems/nix-src that referenced this pull request Nov 11, 2024
@edolstra
Revert "Merge pull request NixOS#11826 from DeterminateSystems/revert…
f29e786 
…-11804"

This reverts commit aeffdef, reversing
changes made to 723fdeb.
This was referenced Nov 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk fricklerhandwerk is a code owner

Assignees
No one assigned
Labels
c api Nix as a C library with a stable interface documentation fetching Networking with the outside (non-Nix) world, input locking new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edolstra @nixos-discourse @Mic92