Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old make (attempt 2) #11850

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Remove old make (attempt 2) #11850

merged 1 commit into from
Nov 11, 2024

Conversation

edolstra
Copy link
Member

Motivation

Reverts the revert in #11826 now that we've branched Nix 2.25.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@edolstra
Revert "Merge pull request NixOS#11826 from DeterminateSystems/revert…
f29e786 
…-11804"

This reverts commit aeffdef, reversing
changes made to 723fdeb.
@github-actions github-actions bot added documentation new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority store Issues and pull requests concerning the Nix store fetching Networking with the outside (non-Nix) world, input locking c api Nix as a C library with a stable interface labels Nov 11, 2024
@Ericson2314
Copy link
Member

Thank you!

@edolstra edolstra merged commit 200f45e into NixOS:master Nov 11, 2024
11 checks passed
@edolstra edolstra deleted the remove-old-make-attempt-2 branch November 11, 2024 16:52
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-11-06-nix-team-meeting-minutes-192/55847/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk fricklerhandwerk is a code owner

Assignees
No one assigned
Labels
c api Nix as a C library with a stable interface documentation fetching Networking with the outside (non-Nix) world, input locking new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edolstra @Ericson2314 @nixos-discourse