Improve build sytem support for readline instead of editline #9728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
repl
|
|
wegank
reviewed
Jan 9, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
wegank
approved these changes
Jan 9, 2024
Changes: - CPP variable is now `USE_READLINE` not `READLINE` - `configure.ac` supports with new CLI flag - `package.nix` supports with new configuration option - `flake.nix` CIs this (along with no markdown) Remove old Ubuntu 16.04 stop-gap too, as that is now quite old. Motivation: - editline does not build for Windows, but readline *should*. (I am still working on this in Nixpkgs at this time, however. So there will be a follow-up Nix PR removing the windows-only skipping of the readline library once I am done.) - Per https://salsa.debian.org/debian/nix/-/blob/master/debian/rules?ref_type=heads#L27 and NixOS#2551, Debian builds Nix with readline. Now we better support and CI that build configuration. This is picking up where NixOS#2551 left off, ensuring we test a few more things not merely have CPP for them. Co-authored-by: Weijia Wang <[email protected]>
Ericson2314
force-pushed
the
readline-support
branch
from
a3b7a9d
to
2cea88d
Compare
|
@wegank said "LGTM otherwise", and this is quite trivial, so I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPP variable is now
USE_READLINEnotREADLINEconfigure.acsupports with new CLI flagpackage.nixsupports with new configuration optionflake.nixCIs this (along with no markdown)Remove old Ubuntu 16.04 stop-gap too, as that is now quite old.
Motivation
editline does not build for Windows, but readline should. (I am still working on this in Nixpkgs at this time, however. So there will be a follow-up Nix PR removing the windows-only skipping of the readline library once I am done.)
Per https://salsa.debian.org/debian/nix/-/blob/master/debian/rules?ref_type=heads#L27 and repl: give user the choice between libeditline and libreadline #2551, Debian builds Nix with readline. Now we better support and CI that build configuration.
Context
This is picking up where #2551 left off, ensuring we test a few more things not merely have CPP for them.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.