Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termcap: init at 1.3.1 #279491

Merged
merged 1 commit into from
Jan 10, 2024
Merged

termcap: init at 1.3.1 #279491

merged 1 commit into from
Jan 10, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Jan 8, 2024

Description of changes

An old library, but still needed for enabling MinGW support for readline (and gettext?)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank
Copy link
Member Author

wegank commented Jan 8, 2024

@ofborg build pkgsCross.mingwW64.termcap

@Ericson2314
Copy link
Member

Ericson2314 commented Jan 9, 2024

I have some more changes to make to this, but I am happy to just do them and then push here :)

@Ericson2314
Copy link
Member

(I amend the commit to support a few more combinations of builds, properly doing static/shared as expected.)

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 10, 2024
@Ericson2314 Ericson2314 merged commit 78a70be into NixOS:master Jan 10, 2024
21 of 23 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

@wegank wegank deleted the termcap-init branch January 10, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants