-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to nixpkgs-vet #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI doesn't pass due to a forward-looking change.
@@ -1,7 +1,7 @@ | |||
# Contributor documentation | |||
|
|||
[@infinisil](https://github.com/infinisil) is the admin and main developer of this repository, | |||
while everybody in [@NixOS/nixpkgs-check-by-name](https://github.com/orgs/NixOS/teams/nixpkgs-check-by-name) has write access. | |||
while everybody in [@NixOS/nixpkgs-vet](https://github.com/orgs/NixOS/teams/nixpkgs-vet) has write access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todo list for NixOS org owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to rename it myself as a team maintainer :)
@@ -27,12 +27,12 @@ There is no guarantee that the derivation succeeds on systems that don't have [p | |||
but it can be attempted with | |||
|
|||
```bash | |||
nix-build https://github.com/NixOS/nixpkgs-check-by-name/tarball/master -A build | |||
nix-build https://github.com/NixOS/nixpkgs-vet/tarball/master -A build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be true on repository rename
@@ -156,7 +156,7 @@ let | |||
# Tests the tool on the pinned Nixpkgs tree with stable Nix. This is a good sanity check. | |||
nixpkgsCheck = pkgs.callPackage ./nixpkgs-check.nix { | |||
inherit initNix nixpkgs; | |||
nixpkgs-check-by-name = packages.build; | |||
nixpkgs-vet = packages.build; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do a redirect but ehhhh no users other than nixpkgs.
1e1451e
to
b1d5632
Compare
Renamed the repo, and rebased after #97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Oh right, merging #97 created Version 0.1.3 already, I wouldn't have a problem doing another release for the renaming |
Yeah, I think we ought to do that. |
#100
@infinisil I'm not able to rename the repo.