-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error for outside references #97
Conversation
The |
Yeah I'd really like that better, maybe let's keep it simpler for now though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of hate the -
prefix, but I suppose consistency is better.
@philiptaron I think it's kind of important for multiple failures: https://github.com/NixOS/nixpkgs-check-by-name/blob/bed457ebdd725a032d248fc74cb91366372eaa21/tests/multiple-failures/expected |
The after release workflow didn't fire automatically yet again, just like before |
I think this is the culprit: https://github.com/orgs/community/discussions/54574#discussioncomment-10119733 |
Motivated by @teto in #64 (comment), improves the error messages when a path outside a package directory is referenced: