Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish-foreign-env: remove alias to incompatible package #108897

Merged
merged 1 commit into from
Jan 10, 2021
Merged

fish-foreign-env: remove alias to incompatible package #108897

merged 1 commit into from
Jan 10, 2021

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jan 9, 2021

Motivation for this change

The fish-foreign-env and the fishPlugins.foreign-env packages aren't
compatible due to changes in directory layout.

It's better to remove the alias so that the evaluation explicitly fails
instead of allowing silent runtime breakage.

GitHub: see #107834 (comment)
GitHub: see LnL7/nix-darwin#269
GitHub: see nix-community/home-manager#1701
GitHub: see nix-community/home-manager#1702

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien pacien requested review from cole-h and rnhmjoj January 9, 2021 23:56
cole-h
cole-h requested changes Jan 9, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want to reword the release note:

nixpkgs/nixos/doc/manual/release-notes/rl-2103.xml

Line 324 in 9297928

<package>fish-foreign-env</package> is now an alias for the

@pacien pacien force-pushed the fish-foreign-env-remove-alias branch from b579466 to 9dce0f2 Compare January 9, 2021 23:59
@pacien pacien requested a review from cole-h January 9, 2021 23:59
cole-h
cole-h reviewed Jan 10, 2021
View reviewed changes
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@pacien
fish-foreign-env: remove alias to incompatible package
052f58f 
The fish-foreign-env and the fishPlugins.foreign-env packages aren't
compatible due to changes in directory layout.

It's better to remove the alias so that the evaluation explicitly fails
instead of allowing silent runtime breakage.

GitHub: see NixOS#107834 (comment)
GitHub: see LnL7/nix-darwin#269
GitHub: see nix-community/home-manager#1701
GitHub: see nix-community/home-manager#1702
@pacien pacien force-pushed the fish-foreign-env-remove-alias branch from 9dce0f2 to 052f58f Compare January 10, 2021 00:03
@pacien pacien requested a review from cole-h January 10, 2021 00:04
cole-h
cole-h approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 10, 2021
rnhmjoj
rnhmjoj approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were right: it's better to fail explicitly since it's actually incompatible.

@rnhmjoj rnhmjoj merged commit db0adc9 into NixOS:master Jan 10, 2021
@NickHu NickHu mentioned this pull request Jan 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacien @rnhmjoj @cole-h