Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "nodePackages: regenerate with node2nix 1.9.0" #110752

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 25, 2021

Reverts #110545

@svanderburg

This breaks eval on master because zigbee2mqtt can't be currently updated. If it is updated nixpkgs-review fails with error: stack overflow (possible infinite recursion) if no ofborg eval results are available.

I've reopened #110394 which does not update zigbee2mqtt which avoids this.

@svanderburg
Copy link
Member

@SuperSandro2000 let's revert it. Weird situation.

@SuperSandro2000
Copy link
Member Author

Same happened in aaf4ddd already.

@SuperSandro2000 SuperSandro2000 merged commit 1703d7a into master Jan 25, 2021
@SuperSandro2000 SuperSandro2000 deleted the revert-110545-node2nix-update branch January 25, 2021 10:47
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 let's revert it. Weird situation.

Ah possible solution right now would be to follow @raboof way to only update node2nix to 1.9.0 without regenerating zigbee2mqtt but still getting the node2nix 1.9.0 files in.

@svanderburg
Copy link
Member

maybe @raboof can also cherry pick some of my changes (e.g. the spacegun fix)

@SuperSandro2000
Copy link
Member Author

maybe @raboof can also cherry pick some of my changes (e.g. the spacegun fix)

He indicated on IRC that you should continue this. Maybe you should try to contact him to coordinate this.

@raboof
Copy link
Member

raboof commented Jan 25, 2021

maybe @raboof can also cherry pick some of my changes (e.g. the spacegun fix)

He indicated on IRC that you should continue this. Maybe you should try to contact him to coordinate this.

TBQH I think @svanderburg is more qualified to take this on, but if I find some time I'll try and update #110394 - please don't wait for me though :D

@svanderburg
Copy link
Member

I have created a new PR with a second attempt: #110813

@alyssais
Copy link
Member

Would you mind putting a short description of why you’re reverting something in the commit message in future (could just have been what you said in the PR body here). Makes it easy to see at a glance from the git log why changes were made, which is important when looking through lots of commits. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants