Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agdaPackages.standard-library: 1.6 -> 1.7 #127639

Merged
merged 2 commits into from
Jul 15, 2021
Merged

agdaPackages.standard-library: 1.6 -> 1.7 #127639

merged 2 commits into from
Jul 15, 2021

Conversation

turion
Copy link
Contributor

@turion turion commented Jun 21, 2021 •
edited
Loading

Motivation for this change

Needs to wait until haskellPackages.Agda has updated to 2.6.2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@turion turion marked this pull request as draft June 21, 2021 08:00
@github-actions github-actions bot added the 6.topic: agda "A dependently typed programming language / interactive theorem prover" label Jun 21, 2021
@turion turion mentioned this pull request Jul 14, 2021
Merged
@turion turion changed the base branch from master to haskell-updates July 14, 2021 19:37
@sternenseemann
Copy link
Member

@ofborg test agda

@ofborg ofborg bot requested review from laMudri, alexarice and jwiegley July 14, 2021 19:48
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 14, 2021
@turion turion marked this pull request as ready for review July 14, 2021 19:49
@turion
Copy link
Contributor Author

turion commented Jul 14, 2021

Builds standard-library locally for me

@sternenseemann
Copy link
Member

nixosTests.agda also fails for me locally.

@cdepillabout
Copy link
Member

@ofborg test agda

@turion
agdaPackages.standard-library: 1.6 -> 1.7
027d839
@turion
nixosTests.agda: Adapt to --guardedness requirements
4b97e92 
The one-line test is hard to fix in a readable manner
and doesn't really add value above the hello-world test.
So rather simplify to reduce maintenance.
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jul 15, 2021
@turion
Copy link
Contributor Author

turion commented Jul 15, 2021

@sternenseemann @cdepillabout Should be fixed now with a small change.

@turion
Copy link
Contributor Author

turion commented Jul 15, 2021

@ofborg test agda

@sternenseemann sternenseemann merged commit 65fcd69 into NixOS:haskell-updates Jul 15, 2021
@cdepillabout
Copy link
Member

cdepillabout commented Jul 15, 2021 •
edited
Loading

@turion Thanks!

I was talking to @sternenseemann about this on Matrix, but how would you feel about adding nixosTests.agda and agdaPackages.standard-library to our haskell-updates jobset?

That way you would get pinged in messages like #129606 (comment) whenever those derivations break on the haskell-updates branch. The NixOS/haskell team would then also know to watch out for agda-related stuff in nixpkgs (which I had no idea about before @sternenseemann brought it up).

In order to do this, you'd basically just need to add nixosTests.agda and agdaPackages.standard-library to https://github.com/NixOS/nixpkgs/blob/haskell-updates/pkgs/top-level/release-haskell.nix and send a PR to the haskell-updates branch.

@sternenseemann
Copy link
Member

#130263

@turion turion deleted the dev_agda_stdlib_1.7 branch July 16, 2021 15:10
@turion
Copy link
Contributor Author

turion commented Jul 16, 2021

@turion Thanks!

I was talking to @sternenseemann about this on Matrix, but how would you feel about adding nixosTests.agda and agdaPackages.standard-library to our haskell-updates jobset?

That way you would get pinged in messages like #129606 (comment) whenever those derivations break on the haskell-updates branch. The NixOS/haskell team would then also know to watch out for agda-related stuff in nixpkgs (which I had no idea about before @sternenseemann brought it up).

In order to do this, you'd basically just need to add nixosTests.agda and agdaPackages.standard-library to https://github.com/NixOS/nixpkgs/blob/haskell-updates/pkgs/top-level/release-haskell.nix and send a PR to the haskell-updates branch.

That's a great idea!

In a language with a more stable release cycle, this wouldn't be necessary because a minor compiler version update should not cause breakage in the whole ecosystem. But unfortunately Agda does this, so we should be alert.

@laMudri laMudri mentioned this pull request Jul 31, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laMudri laMudri Awaiting requested review from laMudri

@alexarice alexarice Awaiting requested review from alexarice

@jwiegley jwiegley Awaiting requested review from jwiegley

Assignees
No one assigned
Labels
6.topic: agda "A dependently typed programming language / interactive theorem prover" 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turion @sternenseemann @cdepillabout