-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskellPackages: update stackage and hackage #129606
Conversation
`glibcLocales` only exists when glibc is used. Similar to commit: 8727284 - haskell: only use glibcLocales when using glibc
Fixes `pkgsMusl.elfutils` failing with `recompile with -fPIC`. This was discovered trying to build `pkgsMusl.haskell.compiler.ghcHEAD`.
The library override that was present in the code referred to a name that isn't even used in current GHC bindists. Tested with: NIX_PATH=nixpkgs=. nix-build --no-link -A haskell.compiler.ghc8102Binary --argstr system i686-linux
This commit has been generated by maintainers/scripts/haskell/update-stackage.sh
This commit has been generated by maintainers/scripts/haskell/update-hackage.sh
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
Upstream introduced too strict lower bounds in a new release. Since it's too much hassle to create a new account in their redmine just for this issue, I've used asserts to indicate when this will be able to be removed.
This commit has been generated by maintainers/scripts/haskell/mark-broken.sh
@sternenseemann: Also I didn't realise that the mark-broken script marked maintained packages broken, should this be something done manually instead? |
We can have discussions about this, but the intention was to only ever run the script when either a) no maintained packages are broken or b) get manually exempt or c) have been broken for 7 days. In general the idea is to post the highlight report early in the process and mark broken only directly before merge. Again, this process is fresh, if there are arguments to improve on any of this, I am all ears. PS: In the past hackage2nix threw an error when a maintained package got marked broken. I have silently broken that feature with a recent PR to cabal2nix. But this was accepted on purpose because we want to be able to mark maintained packages broken. We want more packages to be maintained, we have a clear policy how to mark them broken and removing maintainers when their package breaks seems to me to be a) in contradiction to the aim to have more maintainers also b) it seems a bit rude. |
Yeah, I've looked into it, but the upstream patch doesn't apply cleanly on the last release. I'm unsure, but I think downgrading opaleye globally may be fine (or bugging upstream for a new release). |
The source tarball now has DOS line endings for some reason, requiring the use of dos2unix. Also needs a jailbreak since the template-haskell bound has become too strict.
Running the script early is bad in short, because it hides new regressions we may want to fix. |
Upstream issue for cedille: cedille/cedille#162 |
The one-line test is hard to fix in a readable manner and doesn't really add value above the hello-world test. So rather simplify to reduce maintenance.
Now that the Agda stuff is fixed, I'd like to merge this in the next day or so. Here's what I'm planning on marking broken (unless they get fixed in the next 24 hours, or someone absolutely needs me to hold off):
|
It's an odd one to be sure. Seems like the binaries produced by the writer are killed with Also this is quite serious and I would appreciate if someone more familiar with darwin could have a look at that. |
I'm fine with having it marked as broken; we know it currently doesn't work, might as well tell the user at evaluation time that there's work to do in nixpkgs, perhaps they'll contribute vs being disappointed by a compile failure :) I've looked into it shortly, but not figured out how to convince the build to find in which directory to look for So this will need some deeper investigation. |
No problem. Are you thinking that this is something that is only failing on Hydra, but works normally if you run it yourself? |
It happens locally as well, but I have no idea why. |
This commit has been generated by maintainers/scripts/haskell/mark-broken.sh
…sing LC_ALL=C This makes sure that the output list of transitive broken packages will always be ordered the same regardless of the environment you are running from.
This Merge
This PR is the regular merge of the
haskell-updates
branch intomaster
.This branch is being continually built and tested by hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates.
I will aim to merge this PR by 2021-06-12. If I can merge it earlier, there might be successor PRs in that time window. As part of our rotation @cdepillabout will continue these merges from 2021-07-12 to 2021-07-26.
haskellPackages Workflow Summary
Our workflow is currently described in
pkgs/development/haskell-modules/HACKING.md
.The short version is this:
haskell-updates
(normally at the beginning of a merge window).haskell-updates
intomaster
every two weeks.mergeable
job is succeeding on hydra.maintained
package is still broken at the time of merge, we will only merge if the maintainer has been pinged 7 days in advance. (If you care about a Haskell package, become a maintainer!)This is the follow-up to #128993.