-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chromedriver: 91.0.4472.101 -> 92.0.4515.43 and aarch64-darwin support #128979
Conversation
@ofborg eval (Sorry, ofborg's certs recently had an issue, meaning that it was unable to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aarch64-darwin support sounds good to me but there are two additional requirements here:
- The
chromedriver
version must be compatible with the stable Chrom{e,ium} release: https://chromedriver.chromium.org/downloads/version-selection (I guess we could consider extending the Nix expressions to support the beta channel as well if required). upstream-info.json
must be generated automatically viapkgs/applications/networking/browsers/chromium/update.py
Besides resolving the conflicts, is this all that's needed to get this merged? |
I totally forgot this was even still open. Hasn't even newer version been pushed long ago? If so, then I'd close it. |
I'm forgetting aarch64 support in this too. Feel free to make a new PR based on the ideas here @kclejeune (or PR onto my fork). I fear I'll forget again, since I don't need this right now. |
Yes, adding M1 support should be good to go as long as everything in |
b5b4979
to
951a0ab
Compare
@primeos turns out I need this again :) fixed the connflict and added an entry for generating the shasums for aarch64-darwin as is done with the other targers. |
Thanks for taking care of this! I've been so busy during my last semester of school that I completely forgot. |
putting a grain of salt, not sure if it's a result of my setup but it seems it segfaults
|
Someone else opened another PR that already got merged: #152800 |
@primeos what a timing, but the other PR is essentialy exactly the same, so is suffers the same segfault. It will be fixed one day I'm sure. |
Motivation for this change
I need to develop selenium tests, and the chrome team are already release aarch64-darwin binaries.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)