Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromedriver: add support for aarch64-darwin #152800

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

kalekseev
Copy link
Contributor

Motivation for this change

Provide binary for Apple Silicon

Things done

Haven't tested update.py script but change is straightforward.
That change can be incorporated into the next chrome version bump, to make sure that everything works as expected.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 30, 2021
@domenkozar
Copy link
Member

Evaluation seems to fail?

@kalekseev
Copy link
Contributor Author

@domenkozar where do you see the failure? All GitHub actions passed including aarch64-darwin

@domenkozar domenkozar merged commit 18c84ea into NixOS:master Jan 3, 2022
@primeos
Copy link
Member

primeos commented Jan 4, 2022

There was already a PR for this: #128979. @kalekseev did you try running chromedriver ("Tested basic functionality of all binary files (usually in ./result/bin/)" isn't checked). Apparently it might just segfault: #128979 (comment).

(I just now noticed this change during a Chromium update since I wasn't pinged here.)

@kalekseev
Copy link
Contributor Author

@primeos it works with my project's testsuite, it's a standalone binary on macos that nix downloads from release page so I'm not sure how that can segfault (the only idea is a mismatch between chromedriver and chrome version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants