-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging] boost: default to boost 1.77 and refactor #138309
Conversation
Do to the addition of patches in boost-build, boost 1.77 currently fails in the patch phase. Solving that without breaking old versions of boost on darwin is needed. |
Replacing the darwin-specific patch with an equivelent substituteInPlace allows it to work across versions (including 1.77). Still probably a ton of broken packages that wont build without passing boost = boost16x but the PR is ready for review. |
uhd fails but is fixed by bumping to latest 4.1.0.3. I've tried a handful of packages and that's the failure I found so far |
What's blocking this issue now? Is it just |
PR #138309 switched the default to 177 and that broke the build.
PR #138309 switched the default to 177 and that broke the build.
PR #138309 switched the default to 177 and that broke the build.
|
Motivation for this change
Most packages that depend on the boost libraries in nixpkgs are pointing at the unversioned "boost" package. Unversioned boost is currently 1.69.0, which was released in 2018. The default should be the newest boost library available (1.77). I expect build-time breakages, but it should be fairly straightforward to pin broken packages to an older boost revision once they are identified.
The level of divergence (particularly the addition of boost-build) since I submitted #120259, and the fact that I wanted to combine the addition of boost 1.77 into the same PR made it easier to start the request from scratch.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)