Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBTKS: mark as broken on aarch64-darwin #197068

Closed
wants to merge 1 commit into from

Conversation

YorikSar
Copy link
Contributor

Fails with this error on all newer macOS SDKs according to BIC-MNI/EBTKS#7:

/tmp/nix-build-EBTKS-unstable-2017-09-23.drv-0/source/templates/EBTKS/SimpleArray.h:982:9: error: use of undeclared identifier 'finite'; did you mean 'isfinite'?
    if (FINITE(value)) {
        ^
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Fails with this error on all newer macOS SDKs according to
BIC-MNI/EBTKS#7:

/tmp/nix-build-EBTKS-unstable-2017-09-23.drv-0/source/templates/EBTKS/SimpleArray.h:982:9: error: use of undeclared identifier 'finite'; did you mean 'isfinite'?
    if (FINITE(value)) {
        ^
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 21, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1322

@wegank
Copy link
Member

wegank commented Oct 28, 2022

Why not add, as mentioned in the PR,

  NIX_CFLAGS_COMPILE = lib.optionalString (stdenv.isDarwin && stdenv.isAarch64) "-Dfinite=isfinite";

?

@wegank
Copy link
Member

wegank commented Nov 1, 2022

Closing in favor of #198866.

@wegank wegank closed this Nov 1, 2022
@YorikSar YorikSar deleted the ebtks-broken branch November 1, 2022 04:45
@YorikSar
Copy link
Contributor Author

YorikSar commented Nov 1, 2022

@wegank thanks for a proper fix there. I didn't want to potentially disrupt that ecosystem, as described in the upstream pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants