Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EBTKS: fix build on aarch64-darwin #198866

Merged
merged 1 commit into from
Nov 7, 2022
Merged

EBTKS: fix build on aarch64-darwin #198866

merged 1 commit into from
Nov 7, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 1, 2022 •
edited
Loading

Description of changes

BIC-MNI/EBTKS#7

ZHF #199919.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 1, 2022
@wegank wegank mentioned this pull request Nov 1, 2022
Closed
13 tasks
@ofborg ofborg bot requested a review from bcdarwin November 1, 2022 02:23
bcdarwin
bcdarwin approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

tjni
tjni approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. I have little experience in C++ and no time to fix this more properly upstream, but I really appreciate this.

@tjni tjni mentioned this pull request Nov 1, 2022
Closed
13 tasks
@ofborg ofborg bot requested a review from bcdarwin November 7, 2022 14:23
@wegank wegank requested a review from mweinelt November 7, 2022 16:20
@mweinelt mweinelt merged commit 79e84ba into NixOS:master Nov 7, 2022
@wegank wegank deleted the ebtks-darwin branch November 7, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjni tjni tjni approved these changes

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wegank @mweinelt @bcdarwin @tjni