Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/modprobe: replace boot.isContainer with boot.modprobeConfig.enable #197922

Merged
merged 1 commit into from
Nov 28, 2022
Merged

nixos/modprobe: replace boot.isContainer with boot.modprobeConfig.enable #197922

merged 1 commit into from
Nov 28, 2022

Conversation

SuperSandro2000
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Oct 26, 2022
Merged
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 26, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 26, 2022
@SuperSandro2000 SuperSandro2000 mentioned this pull request Oct 26, 2022
Closed
2 tasks
@SuperSandro2000 SuperSandro2000 force-pushed the modprobeconfig branch 2 times, most recently from cc2fa0d to 5220683 Compare October 26, 2022 21:32
@SuperSandro2000 SuperSandro2000 merged commit 543a5be into NixOS:master Nov 28, 2022
@SuperSandro2000 SuperSandro2000 deleted the modprobeconfig branch November 28, 2022 00:35
@SuperSandro2000 SuperSandro2000 mentioned this pull request Dec 9, 2022
Merged
@github-actions github-actions bot mentioned this pull request Dec 9, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Successfully created backport PR #205319 for release-22.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SuperSandro2000