Use upstream settings instead of workarounds to disable unsupported settings #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
changed the title
2 tasks
SuperSandro2000
force-pushed
the
boot-isContainer-cleanup
branch
2 times, most recently
from
5f2c956
to
d9ca50a
Compare
|
NixOS/nixpkgs#197922 didn't make the branch off, backporting |
573
reviewed
Dec 9, 2022
SuperSandro2000
force-pushed
the
boot-isContainer-cleanup
branch
2 times, most recently
from
56a9e30
to
4a81992
Compare
nzbr
added
blocked
|
@SuperSandro2000 Can you do a flake update? The blocking backport-PR has been merged a while ago |
SuperSandro2000
force-pushed
the
boot-isContainer-cleanup
branch
from
4a81992
to
e6503b9
Compare
|
rebased and updated |
nzbr
approved these changes
Jan 30, 2023
SuperSandro2000
added a commit
that referenced
this pull request
Feb 9, 2023
Turns out that it couldn't be removed in #175
KoviRobi
added a commit
to KoviRobi/NixOS-WSL
that referenced
this pull request
Mar 1, 2023
We can support usbip with the Microsoft Store version of WSL (I think that's the one that introduced the change, also turned on WSLg) Related is nix-community#175 (comment) which is where it got disabled, because it wasn't necessary rather than because it broke things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149