Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell.packages.ghc944.X11-xft: add missing build-time dependencies #214129

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

peti
Copy link
Member

@peti peti commented Feb 2, 2023

The packages has additional system dependencies when compiled in the ghc-9.4.x package set.

The packages has additional system dependencies when compiled in the
ghc-9.4.x package set.
@peti peti self-assigned this Feb 2, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 2, 2023
@peti peti merged commit 56f5f40 into master Feb 2, 2023
@peti peti deleted the t/X11-xft branch February 2, 2023 09:15
@sternenseemann
Copy link
Member

As pointed out in #214145 (comment), this packages does not genuinely have more dependencies, but Cabal is overeager in checking PKG_CONFIG_PATH. I would prefer a different way of fixing this, sadly upstream Cabal hasn't come up with a solution yet.

@peti
Copy link
Member Author

peti commented Feb 3, 2023

I am all for implementing a better solution once we know one. Until then, I believe that simply adding the missing dependencies to fix the build is kinda okay. Those are build-time dependencies only and the override we added does not cause any long-term maintenance costs. Also, the ghc-9.4.4 package set is hardly used by anyone at the moment and fixing builds there in an inperfect way is not going to cause trouble to anyone but, like, expert Haskell uses who choose to live on the bleeding edge.

@sternenseemann
Copy link
Member

I'm mostly worried about maintainability here, a better solution is probably doing it like this: #214446

I really hope Cabal 3.10 will include a fix for this that we can somehow backport to 3.8 and 3.9…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants