-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple ghc-9.4.x build fixes #214145
Multiple ghc-9.4.x build fixes #214145
Conversation
13916f1
to
d36950c
Compare
Rebased and switched target to |
fourmolu = overrideCabal (drv: { | ||
libraryHaskellDepends = drv.libraryHaskellDepends ++ [ self.file-embed ]; | ||
}) (disableCabalFlag "fixity-th" super.fourmolu_0_10_1_0); | ||
|
||
# The Haskell library has additional dependencies when compiled with ghc-9.4.x. | ||
X11-xft = addExtraLibraries [pkgs.xorg.libXau pkgs.xorg.libXdmcp pkgs.expat] super.X11-xft; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to haskell/cabal#8455. This override should not be required, as it is clearly a Cabal bug. I would prefer that we not add such workarounds yet, hoping that a patch for the problem will become available.
Another possibility could be using Cabal 3.6 for building Setup.hs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to use GHC 9.4.4 now. Hoping that a patch might emerge on the future doesn't really help me much with that goal.
|
||
# Package 'libpcre2-8', required by 'glib-2.0', not found. | ||
# text >=1.0.0.0 && <1.3. | ||
glib = addExtraLibrary pkgs.pcre2 (doJailbreak super.glib); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same note about haskell/cabal#8455.
# Package 'libpcre2-8', required by 'glib-2.0', not found. | ||
# text >=1.0.0.0 && <1.3. | ||
glib = addExtraLibrary pkgs.pcre2 (doJailbreak super.glib); | ||
cairo = addExtraLibraries [pkgs.pcre2 pkgs.xorg.libXdmcp] (doJailbreak super.cairo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same note about haskell/cabal#8455.
# In addition to the overrides required by glib and cairo, pango needs the | ||
# pkg-config file for mount.pc, which in turn requires a whole lot of other | ||
# pkg-config files. | ||
pango = addExtraLibraries (with pkgs; [pcre2 xorg.libXdmcp util-linuxMinimal libselinux libsepol pcre fribidi libthai libdatrie]) (doJailbreak super.pango); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same note about haskell/cabal#8455.
@sternenseemann , I am not sure what you would like me to do. Are you opposed to merging those fixes? |
See #214446. |
👍 |
All changes tested and verified on
x86_64-linux
.