buildGoModule: format #234511
Merged
buildGoModule: format #234511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yueh-Shun Li <[email protected]>
|
@ShamrockLee I've added you as co-author for this commit. |
ofborg
bot
added
10.rebuild-darwin: 0
12 tasks
|
With #234651, we'll be able to (optionally) outdent everything by one level. Would that be better, or should we go on with the current format change? You're right about the decision to split the formatting change from the spelling change. |
|
We may as well wait a bit and see what people think about #234651 first. |
|
@ShamrockLee I think might just merge this anyway so we have a formatted file for other work to be based on, does that sound okay? |
ShamrockLee
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)