openbrf: fix build #266721
Merged
openbrf: fix build #266721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
MikaelFangel
added
the
0.kind: ZHF Fixes
ghost
suggested changes
Nov 10, 2023
patch BoundaryWeight into BoundaryQuadricWeight and QualityQuadricWeight add eigen to include path as it is no longer in the vcg include directory
pbsds
force-pushed
the
fix-openbrf-1699643814
branch
from
a76ae6b
to
a8f9b0b
Compare
ghost
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
looks good.
FWIW: can use the file reference.brf openbrf reference.brf and can play around with some mesh things and animations. seems to work though i was not able to trigger the code modified in the patch from casual usage.
delroth
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
ZHF: #265948
https://hydra.nixos.org/build/239129983
patch BoundaryWeight into BoundaryQuadricWeight and QualityQuadricWeight
add eigen to include path as it is no longer in the vcg include directory
openbrf
vcglib
This was originally, and superseeds #266190
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)