Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtest: 1.12.1 -> 1.14.0 #282245

Merged
merged 1 commit into from
Feb 10, 2024
Merged

gtest: 1.12.1 -> 1.14.0 #282245

merged 1 commit into from
Feb 10, 2024

Conversation

simonhollingshead
Copy link
Contributor

Description of changes

From v1.13.0 onwards, C++14 or later is required. v1.12.1 supported C++11.

https://github.com/google/googletest/releases/tag/v1.13.0
https://github.com/google/googletest/releases/tag/v1.14.0

As this will require a large rebuild, this change is targeting staging.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt
Copy link
Member

mweinelt commented Feb 7, 2024

The release note URLs should go into the commit message.

@lukegb lukegb merged commit 4034b75 into NixOS:staging Feb 10, 2024
5 of 6 checks passed
@simonhollingshead simonhollingshead deleted the gtest1140 branch February 11, 2024 01:32
@vcunat
Copy link
Member

vcunat commented Feb 19, 2024

@mweinelt
Copy link
Member

Bumping to the latest upstream commit for rapidjson did not help.

@lukegb
Copy link
Contributor

lukegb commented Feb 19, 2024

I'll take a peek at rapidjson unless someone beats me to it

@cbourjau cbourjau mentioned this pull request Feb 20, 2024
13 tasks
@lukegb
Copy link
Contributor

lukegb commented Feb 20, 2024

#290250 for rapidjson

@simonhollingshead
Copy link
Contributor Author

@vcunat I am proposing a fix for libqtdbustest in #290647.

I have found only two(?) other packages I think are impacted and will also provide fixes for those.

@simonhollingshead
Copy link
Contributor Author

@vcunat You've caught a couple more than me. The two I have seen fail are net-cpp and (I believe) itpp, but itpp's logs in hydra are missing and just show an error.

@simonhollingshead
Copy link
Contributor Author

I believe that I've now interacted with all x86-64 linux builds where the error message contains the C++14 gtest error message.

All are associated with this PR, above.

Note that in four cases, I've either nudged an existing version bump PR or filed an update request. These are all cases where upstream have fixed gtest but where there seems to be some complicating factor (e.g. just updating to a new version causes a compile error unrelated to gtest, or one thing can't update until some other thing is ready). In these cases I feel it's better to defer to maintainers.

@vcunat
Copy link
Member

vcunat commented Feb 23, 2024

Amazing amount of work ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants