-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtest: 1.12.1 -> 1.14.0 #282245
gtest: 1.12.1 -> 1.14.0 #282245
Conversation
6810550
to
3dcfe1c
Compare
The release note URLs should go into the commit message. |
So, who will be dealing with packages that use older C++? |
Bumping to the latest upstream commit for rapidjson did not help. |
I'll take a peek at rapidjson unless someone beats me to it |
#290250 for rapidjson |
@vcunat You've caught a couple more than me. The two I have seen fail are net-cpp and (I believe) itpp, but itpp's logs in hydra are missing and just show an error. |
I believe that I've now interacted with all x86-64 linux builds where the error message contains the C++14 gtest error message. All are associated with this PR, above. Note that in four cases, I've either nudged an existing version bump PR or filed an update request. These are all cases where upstream have fixed gtest but where there seems to be some complicating factor (e.g. just updating to a new version causes a compile error unrelated to gtest, or one thing can't update until some other thing is ready). In these cases I feel it's better to defer to maintainers. |
Amazing amount of work ❤️ |
Description of changes
From v1.13.0 onwards, C++14 or later is required. v1.12.1 supported C++11.
https://github.com/google/googletest/releases/tag/v1.13.0
https://github.com/google/googletest/releases/tag/v1.14.0
As this will require a large rebuild, this change is targeting staging.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.