Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libqtdbustest: unstable-2017-01-06 -> 0.3.2; libqtdbusmock: unstable-2017-03-16 -> 0.9.1 #290647

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

simonhollingshead
Copy link
Contributor

@simonhollingshead simonhollingshead commented Feb 22, 2024

Description of changes

https://gitlab.com/ubports/development/core/libqtdbustest/-/blob/0.3.2/ChangeLog
https://gitlab.com/ubports/development/core/libqtdbusmock/-/blob/0.9.1/ChangeLog

Note: this changes the source of the repositories. This change is following the same upstream move which Debian has already performed between bookworm and trixie.

This fixes breakage caused by #282245 as newer versions of libqtdbustest use C++17 by default.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@simonhollingshead simonhollingshead marked this pull request as draft February 22, 2024 15:48
@ofborg ofborg bot requested a review from OPNA2608 February 22, 2024 16:03
@simonhollingshead simonhollingshead force-pushed the libqtdbustest-0.3.2 branch 2 times, most recently from bc81b88 to 78b8860 Compare February 22, 2024 16:10
@simonhollingshead simonhollingshead mentioned this pull request Feb 22, 2024
13 tasks
@simonhollingshead simonhollingshead changed the title libqtdbustest: unstable-2017-01-06 -> 0.3.2 libqtdbustest: unstable-2017-01-06 -> 0.3.2; libqtdbusmock: unstable-2017-03-16 -> 0.9.1 Feb 22, 2024
@simonhollingshead simonhollingshead force-pushed the libqtdbustest-0.3.2 branch 3 times, most recently from 34b9600 to 0280e93 Compare February 22, 2024 16:44
@simonhollingshead
Copy link
Contributor Author

I'm going to first fix lomiri-thumbnailer (which is failing for a similar reason but I don't want to lump everything into one change), and then come back and clean up this one.

@ofborg ofborg bot requested a review from OPNA2608 February 22, 2024 17:10
@simonhollingshead simonhollingshead marked this pull request as ready for review February 22, 2024 17:20
@K900 K900 merged commit 98c498c into NixOS:staging-next Feb 22, 2024
22 of 23 checks passed
@simonhollingshead simonhollingshead deleted the libqtdbustest-0.3.2 branch March 2, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants