Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME: 45 → 46 #291339

Merged
merged 174 commits into from
May 3, 2024
Merged

GNOME: 45 → 46 #291339

merged 174 commits into from
May 3, 2024

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented Feb 25, 2024

This draft PR starts update work for the upcoming GNOME 46 release.

How to help

  • test running your system from this branch (warning: you might not be able to roll back to 45 without dropping all configuration)
  • test running new versions of software from this branch
  • check hydra builds
    1. look at the latest evaluation in the jobset
    2. check the newly/still failing jobs tab, look for red crosses ❌
    3. open the individual failures' logs
    4. if you see any failures that look like dependency issue or anything that could be caused by this PR, report it in a comment, or open a PR against gnome-46 branch, if you are able to.
  • report any and all problems!

Needs work

  • Test and fix darwin stuff
  • g-c-c g-r-d doesn't support password generation: WARNING: Failed to open file: Error opening file /usr/share/dict/linux.words: No such file or directory
    • consider setting environment.wordlist.enable = true as part of g-r-d? not enough by itself, would still need to patch
  • keyring unlocking doesn't use native prompts all of a sudden?
    • cannot repro
  • figure out if there's been any implementation changes that require something on our side for mounting from g-o-a - mounting dav/google accounts?
    • all good
  • snapshot crashes on startup/can't open stream
  • Try the new gi-compile-repository, gi-decompile-typelib and gi-inspect-typelib
    • Decide which output they should belong to (they are in -bin right now)
    • Figure out how the gobject-introspection-wrapped wrapper might be used here (?? tbh idk)
  • loupe/glycin crashes when loading images
    • seems to be sandboxing/bubblewrap related - we need to fix the sandbox patch, the bind mounts make no sense in the context of nix
    • amaxine: bind mounting /nix/store seems a bit more risky than /usr, but it's unclear to me how to instead pass in the linker and each dep
  • write release notes
    • link to official release announcement (see above), mentioning experimental VRR support and GTK renderer changes as notable
    • we no longer ship adwaita-dark by default in 24.05 as it's not supported - remember to update your configuration accordingly (gnome-themes-extra, gnome-theme-extra: depends on both gtk2 and gtk3 #277944)
    • new g-r-d features as before first require being explicitly enabled in nix (services.gnome.gnome-remote-desktop.enable)
  • add jxl support where necessary
  • GNOME-adjacent desktop breakages (@bobby285271)
  • glib/g-i circular dependency
  • gcr/gnome-keyring ssh-agent changes https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/770
    • currently disabling gcr ssh-agent and enabling gnome-keyring ssh-agent
  • glycin-loaders doesn't build (see commit)
  • all of gstreamer needs updating to 1.24
  • fix gjs test failures
  • fix libshumate test failures
  • fix gst-python test failures
  • fix gnome-remote-desktop/freerdp building
  • actually test evolution/evolution-ews (spamassassin tests don't pass so I've not built it)

Nice to have

Related

Closes #282102
Closes #300620
Closes #300634
Closes #301052
Closes #299414
Closes #292187

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 25, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 26, 2024
@amaxine amaxine force-pushed the gnome-46 branch 3 times, most recently from e85baa7 to d5ef839 Compare March 4, 2024 00:24
@amaxine

This comment was marked as outdated.

@amaxine amaxine force-pushed the gnome-46 branch 2 times, most recently from 3dca364 to 0903b7c Compare March 8, 2024 15:26
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 8, 2024
@amaxine amaxine force-pushed the gnome-46 branch 2 times, most recently from 1981f60 to fab5137 Compare March 8, 2024 21:48
@bobby285271

This comment was marked as outdated.

@bobby285271
Copy link
Member

bobby285271 commented Mar 10, 2024

With 2209d11 + 016a02c + 14436ce, all gnome-maps tests pass for me

Note that gobject-introspection 1.79 no longer installs GLib introspection data (instead this is provided by GLib itself), this causes some build failures like libical and libsecret because their test overrides GI_TYPELIB_PATH, or GI_TYPELIB_PATH is not properly set (I would expect gobject-introspection's setup-hook doing this). It is unclear how many breakages this will cause yet.


Related: #291339 (comment)

Here are some of the fixes related to this change in this PR:

  • 620991b ayatana-indicator-messages: Don't reset GI_TYPELIB_PATH
  • 70aad63 libsecret: Use env.prepend() for test environment setup
  • 9719df6 xdg-desktop-portal: Add missing gobject-introspection
  • 8de37dc libical: Fix typo in test env setup
  • 10a9729 python3Packages.python-dbusmock: Add missing gobject-introspection

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 12, 2024
@amaxine

This comment was marked as resolved.

@amaxine

This comment was marked as resolved.

@jonringer

This comment was marked as off-topic.

@jonringer

This comment was marked as off-topic.

@vcunat

This comment was marked as off-topic.

@amaxine

This comment was marked as off-topic.

@jonringer

This comment was marked as off-topic.

@rhendric
Copy link
Member

Thank you for corralling all of this, @amaxine!

@vcunat
Copy link
Member

vcunat commented Apr 23, 2024

  • The merge broke glib build on aarch64-darwin (and maybe more):
    Program g-ir-scanner found: NO
    
    meson.build:2553:14: ERROR: Program 'g-ir-scanner' not found or not executable
    

@linsui
Copy link
Contributor

linsui commented Apr 23, 2024

Should I target my PR depending on this PR to staging-next?

@jtojnar
Copy link
Member

jtojnar commented Apr 23, 2024

Yes, please target staging-next.

@bobby285271
Copy link
Member

bobby285271 commented Apr 23, 2024

#291339 (comment)

More specifically it is the first glib used to bootstrap the first gobject-introspection that fails. Some merge conflicts are wrongly resolved I guess, in the original fixup I would expect also build man page on darwin and have (lib.mesonEnable "introspection" withIntrospection) on darwin.

@vcunat
Copy link
Member

vcunat commented Apr 23, 2024

For reference, glib should be fixed by PR #306215

@bobby285271 bobby285271 mentioned this pull request Apr 23, 2024
13 tasks
@JohnRTitor JohnRTitor mentioned this pull request May 1, 2024
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 3, 2024
@networkException networkException mentioned this pull request May 3, 2024
13 tasks
@vcunat vcunat merged commit 6162a4e into master May 3, 2024
24 checks passed
@PerchunPak
Copy link
Member

Daily driving GNOME 46 for a few weeks already, so far no problems, just enjoying this release

@jcmolinajr
Copy link

Daily driving GNOME 46 for a few weeks already, so far no problems, just enjoying this release

Pardon my ignorance. How can I try 46 already?

@peigongdsd
Copy link
Contributor

peigongdsd commented May 4, 2024

Daily driving GNOME 46 for a few weeks already, so far no problems, just enjoying this release

Pardon my ignorance. How can I try 46 already?

Use staging-next branch of nixpkgs.

P.S. maybe master branch now...

@PaulGrandperrin
Copy link
Contributor

It's in master and unstable-small but not unstable yet: https://nixpk.gs/pr-tracker.html?pr=291339

@Lyndeno
Copy link
Contributor

Lyndeno commented May 5, 2024

Polkit authentication, via pkexec or 1password, fails as the password prompt does not show up on Gnome 46

@jtojnar jtojnar deleted the gnome-46 branch May 5, 2024 09:57
@Andreas02-dev
Copy link

Daily driving GNOME 46 for a few weeks already, so far no problems, just enjoying this release

Pardon my ignorance. How can I try 46 already?

Friendly ping to let you know it is now also available in NixOS Unstable.

@linuxmobile
Copy link

Friendly ping to let you know it is now also available in NixOS Unstable.

It's Ready.

image

@BillHuang2001
Copy link
Contributor

BillHuang2001 commented May 6, 2024

After upgrading to Gnome 46 on nixos-unstable, I am experiencing a "click-through" bug, which makes many full-screen apps/games unusable. I noticed the issue is marked resolved on GitLab, perhaps there are some missing patches?

@Aleksanaa
Copy link
Member

For people wanting to report bugs, please open a new issue.

@vcunat
Copy link
Member

vcunat commented May 6, 2024

At a quick glance in their gitlab, that bug would seem fixed by mutter 46.1 which is in nixpkgs master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: cinnamon Desktop environment 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet