Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d-spy: 1.8.0 -> 1.9.0 #294441

Closed
wants to merge 1 commit into from
Closed

d-spy: 1.8.0 -> 1.9.0 #294441

wants to merge 1 commit into from

Conversation

Aleksanaa
Copy link
Member

Description of changes

Not updating to 1.9.1 because

../src/main.c:84:12: error: implicit declaration of function 'adw_about_dialog_new'; did you mean 'gtk_about_dialog_new'? [-Werror=implicit-function-declaration]
   84 |   dialog = adw_about_dialog_new ();
      |            ^~~~~~~~~~~~~~~~~~~~
      |            gtk_about_dialog_new
../src/main.c:84:12: warning: nested extern declaration of 'adw_about_dialog_new' [-Wnested-externs]
../src/main.c:84:10: error: assignment to 'int *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
   84 |   dialog = adw_about_dialog_new ();
      |          ^
../src/main.c:85:3: error: implicit declaration of function 'adw_about_dialog_set_application_name'; did you mean 'adw_about_window_set_application_name'? [-Werror=implicit-function-declaration]
   85 |   adw_about_dialog_set_application_name (ADW_ABOUT_DIALOG(dialog), _("D-Spy"));
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   adw_about_window_set_application_name
../src/main.c:85:3: warning: nested extern declaration of 'adw_about_dialog_set_application_name' [-Wnested-externs]
../src/main.c:85:42: error: implicit declaration of function 'ADW_ABOUT_DIALOG'; did you mean 'GTK_ABOUT_DIALOG'? [-Werror=implicit-function-declaration]
   85 |   adw_about_dialog_set_application_name (ADW_ABOUT_DIALOG(dialog), _("D-Spy"));
      |                                          ^~~~~~~~~~~~~~~~
      |                                          GTK_ABOUT_DIALOG
../src/main.c:85:42: warning: nested extern declaration of 'ADW_ABOUT_DIALOG' [-Wnested-externs]
../src/main.c:86:3: error: implicit declaration of function 'adw_about_dialog_set_application_icon'; did you mean 'adw_about_window_set_application_icon'? [-Werror=implicit-function-declaration]
   86 |   adw_about_dialog_set_application_icon (ADW_ABOUT_DIALOG(dialog), PACKAGE_ICON_NAME);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   adw_about_window_set_application_icon
../src/main.c:86:3: warning: nested extern declaration of 'adw_about_dialog_set_application_icon' [-Wnested-externs]
../src/main.c:87:3: error: implicit declaration of function 'adw_about_dialog_set_developers'; did you mean 'adw_about_window_set_developers'? [-Werror=implicit-function-declaration]
   87 |   adw_about_dialog_set_developers (ADW_ABOUT_DIALOG(dialog), authors);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   adw_about_window_set_developers
../src/main.c:87:3: warning: nested extern declaration of 'adw_about_dialog_set_developers' [-Wnested-externs]
../src/main.c:88:3: error: implicit declaration of function 'adw_about_dialog_set_designers'; did you mean 'adw_about_window_set_designers'? [-Werror=implicit-function-declaration]
   88 |   adw_about_dialog_set_designers (ADW_ABOUT_DIALOG(dialog), artists);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   adw_about_window_set_designers
../src/main.c:88:3: warning: nested extern declaration of 'adw_about_dialog_set_designers' [-Wnested-externs]
../src/main.c:92:3: error: implicit declaration of function 'adw_about_dialog_set_version'; did you mean 'gtk_about_dialog_set_version'? [-Werror=implicit-function-declaration]
   92 |   adw_about_dialog_set_version (ADW_ABOUT_DIALOG(dialog), SYMBOLIC_VERSION);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   gtk_about_dialog_set_version
../src/main.c:92:3: warning: nested extern declaration of 'adw_about_dialog_set_version' [-Wnested-externs]
../src/main.c:94:3: error: implicit declaration of function 'adw_about_dialog_set_copyright'; did you mean 'gtk_about_dialog_set_copyright'? [-Werror=implicit-function-declaration]
   94 |   adw_about_dialog_set_copyright (ADW_ABOUT_DIALOG(dialog), "© 2019-2021 Christian Hergert");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   gtk_about_dialog_set_copyright
../src/main.c:94:3: warning: nested extern declaration of 'adw_about_dialog_set_copyright' [-Wnested-externs]
../src/main.c:95:3: error: implicit declaration of function 'adw_about_dialog_set_license_type'; did you mean 'gtk_about_dialog_set_license_type'? [-Werror=implicit-function-declaration]
   95 |   adw_about_dialog_set_license_type (ADW_ABOUT_DIALOG(dialog), GTK_LICENSE_GPL_3_0);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   gtk_about_dialog_set_license_type
../src/main.c:95:3: warning: nested extern declaration of 'adw_about_dialog_set_license_type' [-Wnested-externs]
../src/main.c:96:3: error: implicit declaration of function 'adw_about_dialog_set_website'; did you mean 'gtk_about_dialog_set_website'? [-Werror=implicit-function-declaration]
   96 |   adw_about_dialog_set_website (ADW_ABOUT_DIALOG(dialog), PACKAGE_WEBSITE);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   gtk_about_dialog_set_website
../src/main.c:96:3: error: implicit declaration of function 'adw_about_dialog_set_website'; did you mean 'gtk_about_dialog_set_website'? [-Werror=implicit-function-declaration]
   96 |   adw_about_dialog_set_website (ADW_ABOUT_DIALOG(dialog), PACKAGE_WEBSITE);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   gtk_about_dialog_set_website
../src/main.c:96:3: warning: nested extern declaration of 'adw_about_dialog_set_website' [-Wnested-externs]
../src/main.c:97:3: error: implicit declaration of function 'adw_about_dialog_set_issue_url'; did you mean 'adw_about_window_set_issue_url'? [-Werror=implicit-function-declaration]
   97 |   adw_about_dialog_set_issue_url (ADW_ABOUT_DIALOG(dialog), "https://gitlab.gnome.org/GNOME/d-spy/-/issues/new");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   adw_about_window_set_issue_url
../src/main.c:97:3: warning: nested extern declaration of 'adw_about_dialog_set_issue_url' [-Wnested-externs]
../src/main.c:101:3: error: implicit declaration of function 'adw_dialog_present' [-Werror=implicit-function-declaration]
  101 |   adw_dialog_present (ADW_DIALOG (dialog), GTK_WIDGET(window));
      |   ^~~~~~~~~~~~~~~~~~
../src/main.c:101:3: warning: nested extern declaration of 'adw_dialog_present' [-Wnested-externs]
../src/main.c:101:23: error: implicit declaration of function 'ADW_DIALOG'; did you mean 'GTK_DIALOG'? [-Werror=implicit-function-declaration]
  101 |   adw_dialog_present (ADW_DIALOG (dialog), GTK_WIDGET(window));
      |                       ^~~~~~~~~~
      |                       GTK_DIALOG
../src/main.c:101:23: warning: nested extern declaration of 'ADW_DIALOG' [-Wnested-externs]

Seems like it's needing a newer version of gtk4/libadwaita.

This update is tested.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Aleksanaa Aleksanaa requested a review from a team March 9, 2024 06:44
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Mar 9, 2024
@amaxine
Copy link
Contributor

amaxine commented Mar 9, 2024

d-spy follows the pattern of odd releases being unstable (tags are respectively labelled 46.beta and 46.rc). This will be covered by #291339.

@Aleksanaa
Copy link
Member Author

Thanks for pointing out!

@Aleksanaa Aleksanaa closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants