textlint: repackage with buildNpmPackage #312471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
textlint isn't useful without rules and plugins. This change will allow to provide a wrapper that can use them, using `textlint.withPackages [ xxx ]` like the Python environment.
|
@ofborg build textlint textlint.tests |
There is no lock file in this package, but it is old and stable enough so that we handle dependencies manually.
|
Result of 15 packages built successfully:
|
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #229475
textlintand its rules were introduced in the following PRs (#53981 and #54443) but merged without any idea of how textlint works in nixpkgs.As noted in these PRs, textlint isn't useful without rules and plugins.
This change will allow us to provide a wrapper to use them, using
textlint.withPackages [ xxx ]like the Python environment.This PR has a little too many commits, but the important parts are the first three.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.