-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add textlint to nodePackages #53981
add textlint to nodePackages #53981
Conversation
Okay this is my first contribution so it's gonna take me a bit to work through the checklist. I've never tested from a fork before so I'm going to work from this, assuming that that's the right doc. |
looks good to me, though i'm new to nix as well, so i don't know if it says much. you should be aware that a merge might take a while, because a few packages got bumped up in version, so anything they depend on will probably need to be tested. good luck! |
Do you really need this available for all versions of nodejs? |
@adisbladis No, I definitely don't. I just thought that that was best practice. Would it be better to just provide an update for v10? |
769d691
to
4a45999
Compare
@adisbladis I've gone and restricted this to v10. |
I fixed up the commit message to match https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md. Thank you :) |
I have a continuation up here: #54443 |
Motivation for this change
#53781
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)