Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coc-css: migrate from nodePackages #323474

Merged
merged 1 commit into from
Nov 1, 2024
Merged

coc-css: migrate from nodePackages #323474

merged 1 commit into from
Nov 1, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jun 29, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pyrox0 pyrox0 force-pushed the nodepackages/coc-css-init branch 3 times, most recently from a8ebfee to d7daabd Compare June 30, 2024 00:49
@pyrox0 pyrox0 force-pushed the nodepackages/coc-css-init branch 2 times, most recently from 78de132 to b955d2b Compare July 14, 2024 18:21
@pyrox0 pyrox0 requested a review from figsoda as a code owner July 14, 2024 18:21
@pyrox0 pyrox0 force-pushed the nodepackages/coc-css-init branch from b955d2b to 9a4b709 Compare July 19, 2024 01:39
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 19, 2024
@pyrox0 pyrox0 changed the title coc-css: remove from nodePackages coc-css: migrate from nodePackages Jul 26, 2024
@pyrox0 pyrox0 force-pushed the nodepackages/coc-css-init branch 3 times, most recently from 707e19b to d1122a8 Compare August 2, 2024 19:44
@pyrox0 pyrox0 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 27, 2024
@natsukium
Copy link
Member

Result of nixpkgs-review pr 323474 at d1122a8 run on x86_64-linux 1

3 packages built successfully:
  • coc-css
  • vimPlugins.coc-css
  • vimPluginsUpdater

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
PerchunPak
PerchunPak approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see also #327171

CC @GaetanLepage

@GaetanLepage
Copy link
Contributor

LGTM, please deal with the merge conflicts for me to be able to merge.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 17, 2024
@pyrox0
Copy link
Member Author

pyrox0 commented Oct 17, 2024

LGTM, please deal with the merge conflicts for me to be able to merge.

fixed

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 323474

x86_64-linux

✅ 3 packages built:
  • coc-css
  • vimPlugins.coc-css
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.coc-css
  • vimPluginsUpdater

x86_64-darwin

❌ 1 package failed to build:
  • vimPlugins.coc-css
✅ 1 package built:
  • vimPluginsUpdater

aarch64-darwin

❌ 1 package failed to build:
  • vimPlugins.coc-css
✅ 1 package built:
  • vimPluginsUpdater

@GaetanLepage
Copy link
Contributor

Darwin failure log:

Running phase: configurePhase
no configure script, doing nothing
Executing yarnConfigHook
yarn config v1.22.22
error Error: EEXIST: file already exists, mkdir '/nix/store/ha7f20d8g038gpzlmklcjgfgbblbg6fs-offline'
info Visit https://yarnpkg.com/en/docs/cli/config for documentation about this command.

@pyrox0
Copy link
Member Author

pyrox0 commented Oct 24, 2024

Darwin failure log:

Running phase: configurePhase
no configure script, doing nothing
Executing yarnConfigHook
yarn config v1.22.22
error Error: EEXIST: file already exists, mkdir '/nix/store/ha7f20d8g038gpzlmklcjgfgbblbg6fs-offline'
info Visit https://yarnpkg.com/en/docs/cli/config for documentation about this command.

I don't know what's happening there, seems like a darwin-specific issue or something considering that it worked fine on linux. I can't test darwin errors as I only have a linux machine.

@Aleksanaa Aleksanaa self-requested a review October 27, 2024 05:53
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 29, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 323474

x86_64-linux

✅ 3 packages built:
  • coc-css
  • vimPlugins.coc-css
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.coc-css
  • vimPluginsUpdater

x86_64-darwin

✅ 2 packages built:
  • vimPlugins.coc-css
  • vimPluginsUpdater

aarch64-darwin

✅ 2 packages built:
  • vimPlugins.coc-css
  • vimPluginsUpdater

GaetanLepage
GaetanLepage approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be fine now.
I guess that the darwin rework has helped, or maybe it's something else.
Anyway, merging.

@GaetanLepage GaetanLepage merged commit 0f955c4 into NixOS:master Nov 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerchunPak PerchunPak PerchunPak approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@smancill smancill smancill approved these changes

@figsoda figsoda Awaiting requested review from figsoda

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees
No one assigned
Labels
6.topic: nodejs 6.topic: vim 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pyrox0 @natsukium @GaetanLepage @smancill @PerchunPak @wegank