coc-pyright: migrate from nodePackages #327171
Merged
+35
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrox0
force-pushed
the
nodepackages/coc-pyright
branch
3 times, most recently
from
685bf1c
to
df6f728
Compare
smancill
reviewed
Aug 23, 2024
| @@ -342,6 +343,12 @@ | |||
| src = "${coc-diagnostic}/lib/node_modules/coc-diagnostic"; | |||
| }; | |||
|
|
|||
| coc-pyright = buildVimPlugin { | |||
| pname = "coc-nginx"; | |||
There was a problem hiding this comment.
Shouldn't it be "coc-pyright"?
There was a problem hiding this comment.
Yes, thank you for noticing that!
|
Why though? |
pyrox0
force-pushed
the
nodepackages/coc-pyright
branch
from
df6f728
to
eaff6e7
Compare
|
Still, why move this package from |
See #229475 |
|
I think this is ok to merge, but I'd like another person agreeing with it. I am not much aware with the situation about node packages. |
|
Result of 3 packages built:
|
PerchunPak
approved these changes
Aug 31, 2024
|
|
||
| buildNpmPackage { | ||
| pname = "coc-pyright"; | ||
| version = "1.1.371"; |
There was a problem hiding this comment.
Looks like there is a new release, how about updating?
fannheyward/coc-pyright@7a76586
natsukium
approved these changes
Sep 8, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrates this package from the nodePackages set, and updates the vimPlugins set so that it pulls from the top-level package instead of the one in the nodePackages set.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.