Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coc-pyright: migrate from nodePackages #327171

Merged
merged 1 commit into from
Sep 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkgs/applications/editors/vim/plugins/overrides.nix
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
arrow-cpp
, Cocoa
, coc-diagnostic
, coc-pyright
, code-minimap
, dasht
, deno
Expand Down Expand Up @@ -349,6 +350,12 @@
src = "${coc-diagnostic}/lib/node_modules/coc-diagnostic";
};

coc-pyright = buildVimPlugin {
pname = "coc-pyright";
inherit (coc-pyright) version meta;
src = "${coc-pyright}/lib/node_modules/coc-pyright";
};

coc-nginx = buildVimPlugin {
pname = "coc-nginx";
inherit (nodePackages."@yaegassy/coc-nginx") version meta;
Expand Down Expand Up @@ -2234,7 +2241,6 @@
"coc-metals"
"coc-pairs"
"coc-prettier"
"coc-pyright"
"coc-python"
"coc-r-lsp"
"coc-rls"
Expand Down
27 changes: 27 additions & 0 deletions pkgs/by-name/co/coc-pyright/package.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
lib,
buildNpmPackage,
fetchFromGitHub,
}:

buildNpmPackage {
pname = "coc-pyright";
version = "1.1.371";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a new release, how about updating?
fannheyward/coc-pyright@7a76586


src = fetchFromGitHub {
owner = "fannheyward";
repo = "coc-pyright";
# No tagged releases, this commit corresponds to the latest release of the package.
rev = "d4cfda2f530622962a2a6e3ac1ddb2ad83ea2387";
hash = "sha256-oNixIW63DhPn2LYJ5t/R4xcReZR3W6nqqFBnCUmo/Wo=";
};

npmDepsHash = "sha256-cTAt02RdQbKurP6H/JWwVp+VpoIysbFt9le9R69+DL4=";

meta = {
description = "Pyright extension for coc.nvim";
homepage = "https://github.com/fannheyward/coc-pyright";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ pyrox0 ];
};
}
1 change: 1 addition & 0 deletions pkgs/development/node-packages/aliases.nix
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ mapAliases {
inherit (pkgs) clubhouse-cli; # added 2023-08-18
inherit (pkgs) coc-diagnostic; # added 2024-06-29
coc-imselect = throw "coc-imselect was removed because it was broken"; # added 2023-08-21
inherit (pkgs) coc-pyright; # added 2024-07-14
coinmon = throw "coinmon was removed since it was abandoned upstream"; # added 2024-03-19
coffee-script = pkgs.coffeescript; # added 2023-08-18
inherit (pkgs) concurrently; # added 2024-08-05
Expand Down
1 change: 0 additions & 1 deletion pkgs/development/node-packages/node-packages.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
, "coc-metals"
, "coc-pairs"
, "coc-prettier"
, "coc-pyright"
, "coc-python"
, "coc-r-lsp"
, "coc-rls"
Expand Down
30 changes: 0 additions & 30 deletions pkgs/development/node-packages/node-packages.nix

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.