Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixVersions.git: 2.24.0pre20240723 -> 2.25.0pre20240807 #333183

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Aug 8, 2024

The main goal of the update is to get past the possible upstream fix for NixOS/nix#11265

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The main goal of the update is to get past the possible upstream fix for
NixOS/nix#11265
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 10, 2024
@roberth
Copy link
Member

roberth commented Aug 16, 2024

I don't know why ofborg for aarch64-darwin is still waiting, but it builds for me.

@roberth roberth merged commit d58a8f4 into NixOS:master Aug 16, 2024
38 of 40 checks passed
@trofi trofi deleted the nixVersions.git-update branch August 16, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants