python3Packages.mkdocs-material-insiders: init at 9.5.36-insiders-4.53.13 #343788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
8.has: maintainer-list (update)
NotAShelf
reviewed
Sep 22, 2024
pkgs/development/python-modules/mkdocs-git-committers-plugin-2/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/mkdocs-material-insiders/default.nix
Outdated
Show resolved
Hide resolved
| @@ -7915,6 +7915,8 @@ self: super: with self; { | |||
|
|
|||
| mkdocs-git-authors-plugin = callPackage ../development/python-modules/mkdocs-git-authors-plugin { }; | |||
|
|
|||
| mkdocs-git-committers-plugin-2 = callPackage ../development/python-modules/mkdocs-git-committers-plugin-2 { }; | |||
There was a problem hiding this comment.
I'm a bit rusty on Python packaging, since those are not libraries could they not go under the by-name overlay?
There was a problem hiding this comment.
A little unsure myself, but since they don't expose any binaries and their counterparts are also listed here, I figured this would be the correct location? Not too sure, though.
|
You'll also want to run nixfmt (via nixpkgs-rfc-style) on those packages. |
mahtaran
force-pushed
the
package/python3Packages/mkdocs-material/9.5.36-insiders-4.53.13
branch
from
2e89912
to
1b7ce66
Compare
Signed-off-by: Luka Leer <[email protected]>
|
Thanks for the review! Will force push to fix the formatting in a lil' bit |
mahtaran
force-pushed
the
package/python3Packages/mkdocs-material/9.5.36-insiders-4.53.13
branch
from
1b7ce66
to
ef1e269
Compare
Signed-off-by: Luka Leer <[email protected]>
…3.13 Signed-off-by: Luka Leer <[email protected]>
mahtaran
force-pushed
the
package/python3Packages/mkdocs-material/9.5.36-insiders-4.53.13
branch
from
76949a6
to
b30ee24
Compare
ofborg
bot
added
8.has: package (new)
…9.5.38-insiders-4.53.13 Signed-off-by: Luka Leer <[email protected]>
mahtaran
deleted the
package/python3Packages/mkdocs-material/9.5.36-insiders-4.53.13
branch
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insiders version of Material for MkDocs
Depends on #343787
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.