Plugin with task for verifying contracts on etherscan #2
Conversation
| await env.run("verify-contract", { | ||
| address: deployedAddress, | ||
| contractName: "TestContract1", | ||
| // libraries: JSON.stringify({ |
There was a problem hiding this comment.
Can we add a test case of sources using libraries?
There was a problem hiding this comment.
It's bugged, as it seems from their sample client. Works trough GUI though, will report it.
There was a problem hiding this comment.
Can you add a comment explaining this? And if you report it, can you link the report in the comment? Thanks!
There was a problem hiding this comment.
They are closed source, so I've reported it trough email. This is what I've sent then so you can try it trough https://ropsten.etherscan.io/sourcecode-demo.html . It fails without explanation. They said that are investigating.
So original deployed source is:
https://gist.github.com/mpetrunic/5f219fd480eb633971db12ef6d17b6d0
Params are sent as form data but i'm logging it as json are these:
https://gist.github.com/mpetrunic/322e630b332473355ad26b3dec198d86
They work when submitted trough https://ropsten.etherscan.io/verifyContract2?a=0xda628694fece2e6b79ba14cd06435da1c1a95c39 but not when sent to the api, either directly or via https://ropsten.etherscan.io/sourcecode-demo.html.
There was a problem hiding this comment.
Thanks for the explanation! Can you get back to us when they answer your email?
There was a problem hiding this comment.
Thanks fr review @itirabasso . I'll address issues in the morning
|
@itirabasso @alcuadrado Is this ok? |
Merge pull request NomicFoundation#2 from NodeFactoryIo/master
Tasks:
this pr should resolve issue #1