buidler-etherscan plugin import #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjant
force-pushed
the
buidler-etherscan-import
branch
from
7c7e709
to
33c042b
Compare
alcuadrado
commented
Jul 2, 2019
There was a problem hiding this comment.
What do you think about removing the ContractCompiler class?
I think using run(TASK_COMPILE) and readArtifact should be enough for this plugin.
| @@ -68,7 +68,7 @@ export default function() { | |||
| const packageJson = await getPackageJson(); | |||
| flattened += `// Sources flattened with buidler v${ | |||
| packageJson.version | |||
| } https://getbuidler.com`; | |||
| } https://buidler.dev`; | |||
.gitignore
Outdated
| @@ -90,3 +90,5 @@ typings/ | |||
| # DynamoDB Local files | |||
| .dynamodb/ | |||
|
|
|||
| # Allow a dummy project in this directory for testing purposes | |||
| myproject | |||
There was a problem hiding this comment.
Can you move this to the top-ish of the file? The last part of this gitignore is copied from GH's one. Keeping our things separated will make it easier to maintain.
packages/buidler-etherscan/README.md
Outdated
| @@ -0,0 +1,46 @@ | |||
| [](https://www.npmjs.com/package/@nomiclabs/buidler-etherscan) | |||
|
|
|||
| # buidler-solhint | |||
There was a problem hiding this comment.
We should probably make sure that this follows the boilerplate's readme template. What do you think?
| { | ||
| "name": "@nomiclabs/buidler-etherscan", | ||
| "version": "0.0.1", | ||
| "description": "Buidler TypeScript plugin for verifying contracts on etherscan", |
There was a problem hiding this comment.
I don't get the TS reference, do you?
alcuadrado
commented
Jul 4, 2019
| ); | ||
| } | ||
|
|
||
| console.log({ sourceInTask: source }); |
jjant
force-pushed
the
buidler-etherscan-import
branch
2 times, most recently
from
3a20618
to
c11324e
Compare
jjant
force-pushed
the
buidler-etherscan-import
branch
4 times, most recently
from
50127b3
to
ad8a22c
Compare
jjant
force-pushed
the
buidler-etherscan-import
branch
from
ad8a22c
to
13805a7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin was developed in this PR: NomicFoundation/buidler-etherscan#2
There are a few things that are needed before merging this PR:
WALLET_PRIVATE_KEY="0x1f922fed6c1c5d33c723e1143e1e4e9703aabb5b6a8d9a8aa685c1a08dca726b" npm run test