Gateway routes imported/exported/preferred metrics #477
Conversation
LionelJouin
force-pushed
the
observability-gateway
branch
from
435c6ea
to
5868315
Compare
LionelJouin
added
kind/enhancement
LionelJouin
force-pushed
the
observability-gateway
branch
2 times, most recently
from
213ddb9
to
5254e29
Compare
LionelJouin
changed the title
LionelJouin
force-pushed
the
observability-gateway
branch
from
5254e29
to
46d4c73
Compare
|
Here is a small experiment regarding cpu consumption with 2 exported routes and 1 imported. |
LionelJouin
force-pushed
the
observability-gateway
branch
2 times, most recently
from
95c6cd0
to
78f29ee
Compare
| routesPreferred: 0, | ||
| } | ||
|
|
||
| routes := regex.FindAllString(protocol, -1) |
There was a problem hiding this comment.
Seems like a lot of hassle with all those string operations that follow.
Wouldn't a regex using group matching be easier? https://regex101.com/r/SV8ouF/1
Then you could rely on the single map approach from here: https://stackoverflow.com/questions/60109288/regex-named-groups-in-golang
(You should be looking for 1 match per protocol if I got it right.)
There was a problem hiding this comment.
I don't know, I find it easier to maintain and troubleshoot this than a complex regex
| ctx, | ||
| observer, | ||
| func(birdStats *BirdStats) int64 { | ||
| return int64(birdStats.routesImported) |
There was a problem hiding this comment.
Feels clumsy that the same operation has to be repeated 3 times in the background because 3 values must be extracted. Isn't there some recommendation in opentelemtry how to avoid this?
There was a problem hiding this comment.
No, I don't think opentelemtry gives any recommendation. they are different types of metrics, like rx/tx bytes/packets for an interface.
Btw. with 100 000 IPv4 routes (net prefix /32) in Kind on my machine: |
Thanks for checking this, it seems acceptable. Usually Prometheus should fetch the metrics so often. |
Collect metrics of routes imported, exported and preferred for each gateways. The metrics are extracted and parsed from show protocol all command in bird.
LionelJouin
force-pushed
the
observability-gateway
branch
from
78f29ee
to
fef1cbc
Compare
Description
Collect metrics of routes imported, exported and preferred for each gateways. The metrics are extracted and parsed from show protocol all command in bird.
Issue link
#419
Checklist