-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistency in keeping track of NuGetVersion.OriginalVersion #1329
Conversation
@@ -28,7 +28,7 @@ public NuGetVersion(string version) | |||
/// Creates a NuGetVersion from an existing NuGetVersion | |||
/// </summary> | |||
public NuGetVersion(NuGetVersion version) | |||
: this(version.Version, version.ReleaseLabels, version.Metadata, version.ToString()) | |||
: this(version.Version, version.ReleaseLabels, version.Metadata, version.OriginalVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the culprit.
[InlineData("01.42.0")] | ||
[InlineData("01.0")] | ||
[InlineData("01.42.0-alpha")] | ||
[InlineData("01.42.0-alpha.1")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the above fix, these three SemVer2 versions would fail the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait for a client person's sign-off (@emgarten).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes NuGet/Home#5068