Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown updates for 3.2.0 #4025

Merged
merged 10 commits into from
Aug 29, 2024
Merged

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Aug 15, 2024

@ralfhandl ralfhandl added the approved pr port PRs that just port an approved PR to another version label Aug 15, 2024
@ralfhandl ralfhandl added this to the v3.2.0 milestone Aug 15, 2024
@ralfhandl ralfhandl linked an issue Aug 19, 2024 that may be closed by this pull request
mikekistler
mikekistler previously approved these changes Aug 22, 2024
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl requested a review from miqui August 23, 2024 13:10
Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused as to what happens in which PR, so I'm just going to say the same thing on this one:

@ralfhandl can you re-do this with the tables not expanded since we agreed on that for the other branches? That will keep the change history so much less polluted on this branch.

Ideally I'd prefer not collapsing the spaces after periods, but I'm not going to my heels in on it (but it does create more noise and makes it harder to find sentence changes in a fixed-width editor).

@ralfhandl
Copy link
Contributor Author

The "table condenser" is currently only in #4040. @mikekistler has approved it half a dozen times already, and I'd happily merge it and port it to 3.1.1 and 3.2.0 with a second approval.

@ralfhandl
Copy link
Contributor Author

ralfhandl commented Aug 28, 2024

This is the first part of several PRs to sync 3.2.0 with 3.1.1

We can merge them one by one, thus minimizing the differences, or just merge the last one with the cumulative changes and close the others.

We'll need an additional diff to 3.1.1 to add the changes we did since the last of these PRs was created.

@ralfhandl ralfhandl added editorial Wording and stylistic issues script Pull requests that update Bash or JavaScript code labels Aug 29, 2024

##### Style Examples

Assume a parameter named `color` has one of the following values:

```
```js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't exactly accurate but looks nicer than plain text so OK :-)

@ralfhandl
Copy link
Contributor Author

Merging as @mikekistler has approved before table condensing.

@ralfhandl ralfhandl merged commit ff088f4 into OAI:v3.2.0-dev Aug 29, 2024
1 check passed
@ralfhandl ralfhandl deleted the 3.2.0-markdown-updates branch August 29, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved pr port PRs that just port an approved PR to another version editorial Wording and stylistic issues script Pull requests that update Bash or JavaScript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add whitespace/formatting automation to the build process
3 participants