Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.2.0: replace "property" with "field" or "keyword" where appropriate #4035

Merged
merged 7 commits into from
Sep 9, 2024
Merged

3.2.0: replace "property" with "field" or "keyword" where appropriate #4035

merged 7 commits into from
Sep 9, 2024

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Aug 16, 2024 •
edited
Loading

@ralfhandl ralfhandl added this to the v3.2.0 milestone Aug 16, 2024
@ralfhandl ralfhandl added Housekeeping editorial Wording and stylistic issues labels Aug 16, 2024
@ralfhandl ralfhandl requested review from a team and handrews August 16, 2024 12:19
@ralfhandl ralfhandl mentioned this pull request Aug 16, 2024
Closed
@ralfhandl ralfhandl mentioned this pull request Aug 16, 2024
Merged
@ralfhandl ralfhandl marked this pull request as draft August 16, 2024 12:38
@ralfhandl ralfhandl linked an issue Aug 16, 2024 that may be closed by this pull request
Usage of field vs property #2660
Closed
@ralfhandl ralfhandl added approved pr port PRs that just port an approved PR to another version and removed Housekeeping labels Aug 23, 2024
@ralfhandl ralfhandl mentioned this pull request Aug 28, 2024
Merged
@ralfhandl ralfhandl mentioned this pull request Aug 29, 2024
Closed
This was referenced Sep 2, 2024
Merged
Closed
Closed
@ralfhandl ralfhandl marked this pull request as ready for review September 7, 2024 16:34
mikekistler
mikekistler approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl merged commit d604861 into OAI:v3.2.0-dev Sep 9, 2024
1 check passed
@ralfhandl ralfhandl deleted the 3.2.0-property-field-keyword branch September 9, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekistler mikekistler mikekistler approved these changes

@handrews handrews handrews approved these changes

@miqui miqui Awaiting requested review from miqui

@lornajane lornajane Awaiting requested review from lornajane

Assignees
No one assigned
Labels
approved pr port PRs that just port an approved PR to another version editorial Wording and stylistic issues
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

Usage of field vs property
3 participants
@ralfhandl @handrews @mikekistler