[16.0][IMP] partner_invoicing_mode: Allow better inheritance + use correctly grouping option

[rousseldenis]

Improvements:

• Move the invoicing code to base module from weekly module (and test code).
• Fix the grouping functionality as it does not work if several sale orders have mixed values (for grouping).
• Add a field that compute the next invoice date (e.g.: for the 14 days module, see [ADD] partner_invoicing_mode_fourteen_days #1534)
• Allow to change the grouping option per sale order.

UPDATE:

• Added some hooks to allow changing behavior when validating invoices.
• Uses the grouping function from sale module

[rousseldenis]

@StefanRijnhart @jcoux @TDu

[rafaelbn]

@rousseldenis this módulo is already merged!

https://github.com/OCA/account-invoicing/tree/16.0/partner_invoicing_mode

😄

[rousseldenis]

@rousseldenis this módulo is already merged!

https://github.com/OCA/account-invoicing/tree/16.0/partner_invoicing_mode

😄

Maaaaah, this is an improvement... So, please reopen it

[rafaelbn]

Hahaha! Sorry! After-holidays stuf!!

@StefanRijnhart , please could you review this improvements?

Thank you ! And sorry for the noise! 🙏🏼

[rafaelbn]

I usualy don't like more dependencies , but I leave the review to @TDu and @StefanRijnhart .

[rafaelbn]

So the main big change is using a new dependency. We are not using in this moment this module. I didn't know about it

https://github.com/OCA/server-tools/tree/16.0/base_partition

[rousseldenis]

It's not a big one. Technical one.

[TDu]

I agree, code reuse is always good.

[rafaelbn]

@rousseldenis in case this PR is merged with new dependencies, then a new PR is needed to https://github.com/OCA/account-invoicing/tree/16.0/partner_invoicing_mode_monthly

Is it?

Runbots don't looks like building 🟠

[rousseldenis]

Runbots don't looks like building 🟠

It's not a failed build (not red)

It happens from time to time, relaunching the build is sufficient in most cases.

[rousseldenis]

IMHO @OCA/accounting-maintainers automatic generation of invoices should deserves its own repository

[rafaelbn]

IMHO https://github.com/orgs/OCA/teams/accounting-maintainers automatic generation of invoices should deserves its own repository

I agree, this module prepare to automate but don't automate. We use this one and the others, month, week, etc to classify not to automate

This module just add the periodicity to invoicing, monthly, weekley and so no like terms (due date) or methods (how the pay)

1. Payment term (dates)
2. Payment mode (how)
3. Invoicing period (every xx time or in a concret moment like shipping) <== Invoicing Mode

That's why I don't like to depend in base_partition because then for this so simple function we should leave this module and create a new one simpler for the point 3

Let's see what @TDu and @StefanRijnhart says 😄

It happens from time to time, relaunching the build is sufficient in most cases.

Thank you @rousseldenis !

[rafaelbn]

Tested, I'm unable to make this works see:

test1-16-IMP-partner_invoicing_mode-1515.mp4

[rousseldenis]

That's why I don't like to depend in base_partition because then for this so simple function we should leave this module and create a new one simpler for the point 3

I don't understand the 'why'... This is a helper module that implement a partition on recordsets in order to split them on criteria.

To avoid writing too much code, that one is very useful in many modules. It does not introduces database nor models changes. So not harmful at all. So, don't block for that.

[rousseldenis]

@TDu I have two questions on this as it seems to have not been integrated in OCA module:

• The grouping mode and the invoicing mode on payment mode level
• The ability to define the grouping mode on sale order level separately from configuration on partner or payment mode (as one may want to exclude some sale orders individually)

Thanks for your answers

@jbaudoux

[rousseldenis]

I have answered the first one (not used).

I will implement the second one here too. So, we'll be able to set the grouping option on sale order individually (e.g.: grouping is set on partner but he wants to have a separate invoice for a particular sale order).

[rousseldenis]

@jbaudoux Done

[jbaudoux]

All goods for me.

Would be nice to merge this one as there are many PR depending on it

[rousseldenis]

@OCA/accounting-maintainers

[cyrilmanuel]

hi @sbidoul, @pedrobaeza can you merge this PR please ?

[bosd]

Code review LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[bosd]

@OCA/accounting-maintainers
Or @AaronHForgeFlow Do you have super powers here?

[StefanRijnhart]

/ocabot merge major

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1515-by-StefanRijnhart-bump-major, awaiting test results.

[StefanRijnhart]

I'm afraid merges are stalled by OCA/oca-addons-repo-template#250 too.

[OCA-git-bot]

@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1515-by-StefanRijnhart-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[StefanRijnhart]

/ocabot merge major

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1515-by-StefanRijnhart-bump-major, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 7643aa4. Thanks a lot for contributing to OCA. ❤️