Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP/ADD] shipment_advice*: Add action on shipment advice to print delivery slip and cash on delivery invoices #118

Closed
wants to merge 2 commits into from
Closed

[16.0][IMP/ADD] shipment_advice*: Add action on shipment advice to print delivery slip and cash on delivery invoices #118

wants to merge 2 commits into from

Conversation

tuantrantg
Copy link

@tuantrantg tuantrantg commented Mar 13, 2024 •
edited by jbaudoux
Loading

This PR includes:

  • [IMP] shipment_advice: Add action on shipment advice to print delivery slip
  • [ADD] shipment_advice_cash_on_delivery: Add action on shipment advice to print cash on delivery invoices

Depends on:

@rousseldenis rousseldenis added this to the 16.0 milestone Mar 13, 2024
@tuantrantg tuantrantg marked this pull request as ready for review March 13, 2024 07:55
@tuantrantg tuantrantg changed the title [16.0][IMP] shipment_advice: Add action on shipment advice to print delivery slip [16.0][IMP/ADD] shipment_advice*: Add action on shipment advice to print delivery slip and cash on delivery invoices Mar 14, 2024
@tuantrantg tuantrantg mentioned this pull request Mar 14, 2024
Open
jbaudoux
jbaudoux requested changes Mar 14, 2024
View reviewed changes
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the port. I listed a few remarks

shipment_advice_cash_on_delivery/models/stock_picking.py Show resolved Hide resolved
shipment_advice_cash_on_delivery/readme/CREDITS.rst Outdated Show resolved Hide resolved
shipment_advice_cash_on_delivery/tests/test_shipment_advice_cash_on_delivery.py Outdated Show resolved Hide resolved
shipment_advice_cash_on_delivery/tests/test_shipment_advice_cash_on_delivery.py Outdated Show resolved Hide resolved
@tuantrantg tuantrantg force-pushed the 16.0-imp-shipment_advice branch 2 times, most recently from b60a8bd to f672552 Compare March 15, 2024 03:13
@tuantrantg
Copy link
Author

hi @jbaudoux the PR is updated, please review it again, thank you

@tuantrantg tuantrantg mentioned this pull request Apr 1, 2024
Closed
@tuantrantg
Copy link
Author

hi @jbaudoux could you please review this PR again

rousseldenis
rousseldenis reviewed Apr 3, 2024
View reviewed changes
shipment_advice/models/shipment_advice.py Outdated
@@ -457,3 +457,12 @@ def button_open_receptions_in_progress(self):
action["views"][tree_view_index] = (view_tree.id, "tree")
action["domain"] = [("id", "in", self.planned_picking_ids.ids)]
return action

def print_all_deliveryslip(self):
picking_type = self.env.ref("stock.picking_type_out")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmh, not sure about this one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rousseldenis could you please review it again, I've updated it

jbaudoux
jbaudoux reviewed Apr 4, 2024
View reviewed changes
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. Can you also regenerate README after fixing those?

shipment_advice_cash_on_delivery/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
shipment_advice_cash_on_delivery/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
shipment_advice_cash_on_delivery/tests/test_shipment_advice_cash_on_delivery.py Outdated Show resolved Hide resolved
shipment_advice_cash_on_delivery/tests/test_shipment_advice_cash_on_delivery.py Outdated Show resolved Hide resolved
shipment_advice_cash_on_delivery/tests/test_shipment_advice_cash_on_delivery.py Outdated Show resolved Hide resolved
shipment_advice_cash_on_delivery/tests/test_shipment_advice_cash_on_delivery.py Outdated Show resolved Hide resolved
@tuantrantg tuantrantg force-pushed the 16.0-imp-shipment_advice branch 2 times, most recently from 0a69d8e to 85f3171 Compare April 4, 2024 09:35
jbaudoux
jbaudoux reviewed Apr 8, 2024
View reviewed changes
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add on the form view of the shipment advice (in state done & outgoing), the buttons to print the delivery slips, cash on delivery invoices, shipment advice?
So the same things you can do from the release channel. As the buttons are not visible on purpose on the channel once asleep, we need to be able to open a shipment advice and print from there

@rousseldenis rousseldenis mentioned this pull request Jun 13, 2024
Open
@rousseldenis
Copy link
Contributor

@cyrilmanuel FYI : OCA/account-invoicing#1736

@trisdoan
Copy link

Hello @tuantrantg, @rousseldenis, I took over this PR and prepared #129 to include [REF] shipment_advice_cash_on_delivery: Extract cash on delivery to separate module

@tuantrantg tuantrantg closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@jbaudoux jbaudoux jbaudoux approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

Assignees
No one assigned
Labels
approved enhancement needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tuantrantg @rousseldenis @trisdoan @jbaudoux @cyrilmanuel @OCA-git-bot