[16.0][MIG] account_payment_purchase: Migration to 16.0 #1004

ramiadavid · 2022-12-20T07:02:56Z

#964

etobella · 2022-12-20T07:23:07Z

/ocabot migration account_payment_purchase

flotho

code review,
tested on runboat,
LGTM
Thanks @alexis-via

account_payment_purchase/models/purchase_order.py

account_payment_purchase/tests/test_account_payment_purchase.py

account_payment_purchase/models/purchase_order.py

RodrigoBM

LGTM.

OCA-git-bot · 2023-01-03T13:00:16Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

RodrigoBM · 2023-02-07T09:47:04Z

@etobella can you merge it?

etobella · 2023-02-07T11:37:20Z

account_payment_purchase/tests/test_account_payment_purchase.py

@@ -84,8 +84,8 @@ def test_purchase_order_invoicing(self):
        invoice = self.env["account.move"].create(
            {"partner_id": self.partner.id, "move_type": "in_invoice"}
        )
-        with Form(invoice) as inv:
-            inv.purchase_id = self.purchase
+        invoice.purchase_id = self.purchase


Why are you removing the form? It was done this way in order to keep the same logic done by odoo interface

@etobella AssertionError: can't write on invisible field purchase_id

But with this, you are not testing the real thing, as onchanges are not triggered.

Having a quick look at how is implemented in core: it sucks. It seems to go against the principle of not having business logic in onchanges. Unfortunately, if you don't set force_save="1" on the field it does not work and - BTW - the field is emptied at the end of the onchange.
Also, if you look at _set_purchase_orders they call this onchange explicitly 🤦
Finally, there's no test on their onchange on purchase_id, likely because they cannot test it 😄

However, if you want to keep it like this you should call _onchange_partner_id too IMO.

@simahawk

If I'm not mistaken, the function that is called when the purchase_id field is modified is _onchange_purchase_auto_complete

https://github.com/odoo/odoo/blob/08cf96d9ba169287a7e8d7dece4ac0110fa01742/addons/purchase/models/account_invoice.py#L33:L34

And this is already being called in the test, exactly the same as in the rest of the tests that I have not modified.

bank-payment/account_payment_purchase/tests/test_account_payment_purchase.py

Line 88 in 1102ba6

invoice._onchange_purchase_auto_complete()

Isn't that correct?

I just faced the same issue while porting module account_move_line_purchase_info to V16. I think that this part of test may be written the same way as in standard Odoo:
https://github.com/odoo/odoo/blob/16.0/addons/purchase/tests/test_purchase_order_report.py#L76-L79

Something like this:

with Form(invoice) as inv: inv.purchase_vendor_bill_id = self.env['purchase.bill.union'].browse(-self.purchase.id)

simahawk · 2023-02-23T10:00:42Z

account_payment_purchase/tests/test_account_payment_purchase.py

@@ -84,8 +84,8 @@ def test_purchase_order_invoicing(self):
        invoice = self.env["account.move"].create(
            {"partner_id": self.partner.id, "move_type": "in_invoice"}
        )
-        with Form(invoice) as inv:
-            inv.purchase_id = self.purchase
+        invoice.purchase_id = self.purchase


Having a quick look at how is implemented in core: it sucks. It seems to go against the principle of not having business logic in onchanges. Unfortunately, if you don't set force_save="1" on the field it does not work and - BTW - the field is emptied at the end of the onchange.
Also, if you look at _set_purchase_orders they call this onchange explicitly 🤦
Finally, there's no test on their onchange on purchase_id, likely because they cannot test it 😄

However, if you want to keep it like this you should call _onchange_partner_id too IMO.

simahawk · 2023-02-23T10:02:16Z

account_payment_purchase/tests/test_account_payment_purchase.py

+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.journal = cls.env["account.journal"].create(


Suggested change

cls.journal = cls.env["account.journal"].create(

cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))

cls.journal = cls.env["account.journal"].create(

StephaneMangin · 2023-03-23T12:09:01Z

cc @ramiadavid Any update about the reviews ?

HaraldPanten · 2023-05-31T15:31:03Z

@ramiadavid is this PR ready to review? THX

ramiadavid · 2023-05-31T18:02:59Z

@HaraldPanten I think yes

HaraldPanten · 2023-06-01T09:12:49Z

@ramiadavid Could you rebase, please? I'll test it in runboat. THX!

…_payment_partner - account_payment_sale - account_payment_sale_stock - account_payment_purchase Filter the selection of invoices per payment type. Add active field on payment.mode and payment.mode.type. Add menu entry for Payment Types.

…emo data.

Currently translated at 100.0% (9 of 9 strings) Translation: bank-payment-12.0/bank-payment-12.0-account_payment_purchase Translate-URL: https://translation.odoo-community.org/projects/bank-payment-12-0/bank-payment-12-0-account_payment_purchase/pt_BR/

Currently translated at 100.0% (9 of 9 strings) Translation: bank-payment-12.0/bank-payment-12.0-account_payment_purchase Translate-URL: https://translation.odoo-community.org/projects/bank-payment-12-0/bank-payment-12-0-account_payment_purchase/ca/

Currently translated at 100.0% (8 of 8 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_payment_purchase Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_purchase/pt_BR/

Currently translated at 100.0% (8 of 8 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_payment_purchase Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_purchase/es_AR/

Currently translated at 100.0% (8 of 8 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_purchase Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_purchase/fr_FR/

Currently translated at 62.5% (5 of 8 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_purchase Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_purchase/sv/

…or bank PO - Only issue a warning message if the PO had a non-blank payment mode or bank.

…k id close OCA#899

…ccount Without this fix, the partner_bank_id was being reset to False on change of 'company_id' in the _onchange_purchase_auto_complete method in account.move in the following unit test: def test_from_purchase_order_invoicing_bank That's because in commit 9be9766 we switched to getting payment method from env.ref('account.account_payment_method_manual_out'), which has bank_account_required == False by default, while before that we were creating payment method for which we were explicitly setting bank_account_required as True Also tag unit test as post_install

ramiadavid · 2023-06-01T09:27:52Z

@HaraldPanten done

HaraldPanten

THX David,

Functional review LGTM.

@pedrobaeza GO?

pedrobaeza · 2023-06-01T10:23:00Z

/ocabot migration account_payment_purchase
/ocabot merge nobump

OCA-git-bot · 2023-06-01T10:23:19Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1004-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-06-01T10:31:44Z

Congratulations, your PR was merged at 3a9f94a. Thanks a lot for contributing to OCA. ❤️

ramiadavid mentioned this pull request Dec 20, 2022

Migration to version 16.0 #964

Open

14 tasks

ramiadavid marked this pull request as ready for review December 20, 2022 07:10

OCA-git-bot added this to the 16.0 milestone Dec 20, 2022

flotho approved these changes Dec 21, 2022

View reviewed changes

RodrigoBM reviewed Dec 30, 2022

View reviewed changes

account_payment_purchase/models/purchase_order.py Outdated Show resolved Hide resolved

account_payment_purchase/tests/test_account_payment_purchase.py Outdated Show resolved Hide resolved

ramiadavid force-pushed the 16.0-mig-account_payment_purchase branch from f90f230 to 5c2fe99 Compare December 30, 2022 08:36

RodrigoBM reviewed Dec 30, 2022

View reviewed changes

account_payment_purchase/models/purchase_order.py Outdated Show resolved Hide resolved

ramiadavid force-pushed the 16.0-mig-account_payment_purchase branch from 5c2fe99 to 1102ba6 Compare January 3, 2023 09:03

RodrigoBM approved these changes Jan 3, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 3, 2023

etobella reviewed Feb 7, 2023

View reviewed changes

StephaneMangin approved these changes Feb 23, 2023

View reviewed changes

simahawk reviewed Feb 23, 2023

View reviewed changes

SodexisTeam mentioned this pull request Mar 14, 2023

[16.0][MIG] account_payment_purchase_stock #1063

Merged

ramiadavid force-pushed the 16.0-mig-account_payment_purchase branch from 1102ba6 to b10a653 Compare March 24, 2023 19:15

Alexis de Lattre and others added 7 commits June 1, 2023 11:26

wrapping module description lines to keep cool with the PEP-8 extremists

df5758f

Update to the new data-model decided during the Open Days 2014. Add d…

794886b

…emo data.

Launchpad automatic translations update.

09e507a

Launchpad automatic translations update.

0b08ee1

Initial adjustments for 8.0 repository

9f1c8d3

Migration and enhancement of all modules involved in SEPA

6b1d85a

cubells and others added 20 commits June 1, 2023 11:26

account_payment_purchase module

090dc84

account_payment_purchase: Migration to 10.0

ec61427

account_payment_purchase: Migration to 11.0

850663b

Translated using Weblate (Catalan)

fd134bf

Currently translated at 100.0% (9 of 9 strings) Translation: bank-payment-12.0/bank-payment-12.0-account_payment_purchase Translate-URL: https://translation.odoo-community.org/projects/bank-payment-12-0/bank-payment-12-0-account_payment_purchase/ca/

[IMP] account_payment_purchase: black, isort

9a66745

[MIG] account_payment_purchase: Migration to 13.0

b48955c

Split account_payment_purchase (add account_payment_purchase_stock)

c450a8a

Added translation using Weblate (Spanish (Argentina))

0d4d583

[MIG] account_payment_purchase: Migration to v14

ab2736c

Translated using Weblate (French)

5d35ac0

Currently translated at 100.0% (8 of 8 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_purchase Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_purchase/fr_FR/

Translated using Weblate (Swedish)

8ca37bb

Currently translated at 62.5% (5 of 8 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_purchase Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_purchase/sv/

[account_payment_purchase][fix] Only warn for non-blank payment mode …

77a51dc

…or bank PO - Only issue a warning message if the PO had a non-blank payment mode or bank.

[MIG] account_payment_purchase: Migration to 15.0

ce5da9d

[FIX] account_payment_purchase: solved error get payment mode and ban…

30511f9

…k id close OCA#899

[IMP] account_payment_purchase: pre-commit stuff

5235cb6

[MIG] account_payment_purchase: Migration to 16.0

3094e7e

ramiadavid force-pushed the 16.0-mig-account_payment_purchase branch from b10a653 to 3094e7e Compare June 1, 2023 09:27

HaraldPanten approved these changes Jun 1, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jun 1, 2023

OCA-git-bot merged commit 2fcc748 into OCA:16.0 Jun 1, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] account_payment_purchase: Migration to 16.0 #1004

[16.0][MIG] account_payment_purchase: Migration to 16.0 #1004

ramiadavid commented Dec 20, 2022 •

edited

Loading

etobella commented Dec 20, 2022

flotho left a comment

RodrigoBM left a comment

OCA-git-bot commented Jan 3, 2023

RodrigoBM commented Feb 7, 2023

etobella Feb 7, 2023

ramiadavid Feb 7, 2023

pedrobaeza Feb 23, 2023

simahawk Feb 23, 2023 •

edited

Loading

ramiadavid Feb 26, 2023

astirpe Mar 16, 2023 •

edited

Loading

simahawk Feb 23, 2023 •

edited

Loading

simahawk Feb 23, 2023

ramiadavid Mar 24, 2023

StephaneMangin commented Mar 23, 2023

HaraldPanten commented May 31, 2023

ramiadavid commented May 31, 2023

HaraldPanten commented Jun 1, 2023

ramiadavid commented Jun 1, 2023

HaraldPanten left a comment

pedrobaeza commented Jun 1, 2023

OCA-git-bot commented Jun 1, 2023

OCA-git-bot commented Jun 1, 2023

	cls.journal = cls.env["account.journal"].create(
	cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
	cls.journal = cls.env["account.journal"].create(

[16.0][MIG] account_payment_purchase: Migration to 16.0 #1004

[16.0][MIG] account_payment_purchase: Migration to 16.0 #1004

Conversation

ramiadavid commented Dec 20, 2022 • edited Loading

etobella commented Dec 20, 2022

flotho left a comment

Choose a reason for hiding this comment

RodrigoBM left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 3, 2023

RodrigoBM commented Feb 7, 2023

etobella Feb 7, 2023

Choose a reason for hiding this comment

ramiadavid Feb 7, 2023

Choose a reason for hiding this comment

pedrobaeza Feb 23, 2023

Choose a reason for hiding this comment

simahawk Feb 23, 2023 • edited Loading

Choose a reason for hiding this comment

ramiadavid Feb 26, 2023

Choose a reason for hiding this comment

astirpe Mar 16, 2023 • edited Loading

Choose a reason for hiding this comment

simahawk Feb 23, 2023 • edited Loading

Choose a reason for hiding this comment

simahawk Feb 23, 2023

Choose a reason for hiding this comment

ramiadavid Mar 24, 2023

Choose a reason for hiding this comment

StephaneMangin commented Mar 23, 2023

HaraldPanten commented May 31, 2023

ramiadavid commented May 31, 2023

HaraldPanten commented Jun 1, 2023

ramiadavid commented Jun 1, 2023

HaraldPanten left a comment

Choose a reason for hiding this comment

pedrobaeza commented Jun 1, 2023

OCA-git-bot commented Jun 1, 2023

OCA-git-bot commented Jun 1, 2023

ramiadavid commented Dec 20, 2022 •

edited

Loading

simahawk Feb 23, 2023 •

edited

Loading

astirpe Mar 16, 2023 •

edited

Loading

simahawk Feb 23, 2023 •

edited

Loading