Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] hr_expense_advance_clearing #255

Closed
wants to merge 7 commits into from
Closed

[17.0][MIG] hr_expense_advance_clearing #255

wants to merge 7 commits into from

Conversation

hongquangminh
Copy link
Member

Module migrated to version 17.0

#214

@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

Please also check the red CIs.

@hongquangminh hongquangminh mentioned this pull request Jul 12, 2024
7 tasks
@hongquangminh
Copy link
Member Author

/ocabot migration hr_expense_advance_clearing

@OCA-git-bot
Copy link
Contributor

Sorry @hongquangminh you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@Saran440
Copy link
Member

@hongquangminh Hi, Thank you for your contribution.
I think you forgot to use git format-patch before migrating. The history should be shown in this PR.

However, we use this module in our project. May I migrate it instead of you (I am starting the migration to version 17)? Could you help us review it, please?

@hongquangminh
Copy link
Member Author

@hongquangminh Hi, Thank you for your contribution. I think you forgot to use git format-patch before migrating. The history should be shown in this PR.

However, we use this module in our project. May I migrate it instead of you (I am starting the migration to version 17)? Could you help us review it, please?

Hi @Saran440 , yes please, because I need this module for my business in version 17. And I don't see any migrated PR in this Repo. So that is why I am pushing this PR for official review. As you suggested, I will close this PR and wait for your session. Please ping me if you need to. Thanks!

@hongquangminh hongquangminh deleted the 17.0-mig-hr_expense_advance_clearing branch July 22, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants