[17.0][MIG] hr_expense_advance_clearing #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Saran440
commented
Jul 19, 2024
•
Saran440
commented
- Refactor code for support odoo17
[UPD] Update hr_expense_advance_clearing.pot [UPD] README.rst
Fix install error when there are already some expense in system. [UPD] README.rst hr_expense_advance_clearing 12.0.1.0.1
We should prevent setting the analytic account in expenses used as employees advance. Otherwise, it can lead to errors charging against an analytic account that later won't be compensated when all is reconcile. Anyway, the advance is not an expense, but money of the company moving from one place to another, that later will be used for real expenses that will be imputed to the corresponding analytic account
Currently translated at 100.0% (57 of 57 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_clearing Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_clearing/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_advance_clearing Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_advance_clearing/
Currently translated at 100.0% (56 of 56 strings) Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_advance_clearing Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_advance_clearing/it/
|
@hongquangminh Please, close your PR #255 and help us to review this please? |
|
/ocabot migration hr_expense_advance_clearing |
Thanks for inform me. It look fine now. Btw, can I add the vi.po file for translate? |
|
@hongquangminh yes, you can open new PR to https://github.com/ecosoft-odoo/hr-expense/tree/17.0-mig-hr_expense_advance_clearing or wait this PR merged and translate by https://translation.odoo-community.org/ |
|
when press Return Advance have a error |
|
@gjlong68 Can you please add step to error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.