l10n_ch_base_bank remove isr check #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santostelmo
force-pushed
the
l10n_ch_base_bank_remove_isr_check
branch
2 times, most recently
from
e838443
to
60e824a
Compare
|
It needs a rebase to solve |
This was referenced Jan 3, 2023
|
IMO we can drop much more than the check. The fields that contains the postal number are obscolete too. Which makes the whole module obsolete. |
santostelmo
force-pushed
the
l10n_ch_base_bank_remove_isr_check
branch
from
60e824a
to
bbf1841
Compare
Rebased |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISR is not used anymore in Switzerland => We drop
_check_bank_type_for_type_isr